Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp502527pxj; Thu, 27 May 2021 05:32:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwi7ExULkH+kXoSVVOhzbsCzVc6f5gH3Or64ZOCGxdAPpOVxKHdJBh4R5QkzNSHDpEpdryi X-Received: by 2002:a17:906:d14b:: with SMTP id br11mr3598535ejb.490.1622118726598; Thu, 27 May 2021 05:32:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622118726; cv=none; d=google.com; s=arc-20160816; b=V68/IYRKgeGqW5FNTHI7+AWVUJOFfm0XrVi5Nw0XtfWEgX4LSOrVOA6aDcAf4pWAB4 sa2flOFaHvVGundq6kd+4cGGgVH8pTk0W5y8KAbnF439Fw2yf2Ea8SEUxtrE5ZK1PS2N Y9EkQsPz9+ooo6UKWH99hD5xU0mRPKD2eMwjpIznDrBK1r8gLM+8AQN2ANFonhiP01i4 cI9azAidEfoFT1ldtDj5DMYffu7rAA/PmagpIkTtcUH0oS2srwrYukx23OumU1HGCjKD iu47UG0jNE6RHb5IdUUjXuFgIQrBH+RQFsK9cwYrIY21qNvteyWXor0wywsafLRmFT5T BWYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=fRBr6xZkzmbnPWuRrXfAqA5xA8c0t9k1LP7xSr+ydFk=; b=qtcjNPirmD/5/G7yu3kDc2y+9ovDA900Y7ceMXfDfDgy2gVzySwDWJZIEKZbiOPSUA vQ/28FadNsW4b8XiVDrOfa/wG5MlyS45CPW0lXih9k5190k6/0n6zOwYaXtZN3R9KjuC eYkUpsRsuHUhJPsRlUWjC3fwBZ+GOrT8i9yGuUMEmdPzQ7mivCH2w/vmtrKwkfVTqPEt vgjzKE1dNmJRFE5ftQyuG+cunHWWuGND+j47mKynZlp98RGhKCBCoDyb2XbgHEYZzPYJ hOSh62tiLKv84yUY58n1hVVM9Yxe3NAUBG99hTx38k4n/o1WLEUQwN6ribq2D/hdEINa bzbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cJcApNTb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si1883328edq.476.2021.05.27.05.31.43; Thu, 27 May 2021 05:32:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cJcApNTb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235424AbhE0MbV (ORCPT + 99 others); Thu, 27 May 2021 08:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235247AbhE0MbD (ORCPT ); Thu, 27 May 2021 08:31:03 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8602EC061760 for ; Thu, 27 May 2021 05:29:25 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso5007682wmc.1 for ; Thu, 27 May 2021 05:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=fRBr6xZkzmbnPWuRrXfAqA5xA8c0t9k1LP7xSr+ydFk=; b=cJcApNTb2Db0TXRi89IcQr4nyCEsRga93qLPHyDs6EU05t1h6i/oYDaF12n8b+GavG ZTXVAtZCnQhfQgxMigaLcHpVNLryZuBBpuoW+KlpDBxJ54QVoLEtjvPgnDCkYZ6+SpJO 2F1ysEYzdiZdJ9PUVM4ZgwEEsp8DQWN4MaZmWb6RSReO+9x4XZLMAxkH722s9bc2tS6m bdewnwiQO7ZPndm31rDyT/lUAtMij5Cy6RClkiD6m0x5b4koK80XW+7mBR8bZa/7rgVw c9ZhhwQw3YS0E2+Lc9cLJjDmwMUzc+1oWkkn3adS8EQV8WITToiaSbWN/GdJthsLhKdK tqpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fRBr6xZkzmbnPWuRrXfAqA5xA8c0t9k1LP7xSr+ydFk=; b=cC/g2CogHRybpBTC87lChnBwy8utIKgx0ql9+7XOWf9WmJGqoqp0UhUkE4AlMDAInQ r8W6R1PanWolhPT+zhWcmMeKQA0L46vcLECz9wD4SJzUPgE/4JXJRZe3Goj4V5G37KHU KECxXe5IDDmpfinTNcApJ/hMV8wXvljS4BumsR8bq7Pb+E5VAniluMXJ01DLtACEmpSo MWZ4Oc4p8QMoktxchZNSG0E7jcUSp1aPz1cp8BNcOylvwbs62G/hRtRRFDth+68x4w4p dP8rtpxPLyCykbYUFpJWSMeVZK9Eqj+03SFfOR2phkdGxrtcsWPvedM8FqJiUS6kwl2V xAZw== X-Gm-Message-State: AOAM532q0ofSxx3o9px+RuJNHYvYlJEVSANnXZLwIGpqF7G4WtMF6PcN uOJAfsdcN6VEtveqEZ7Re3xGCA== X-Received: by 2002:a1c:e243:: with SMTP id z64mr3167979wmg.25.1622118563877; Thu, 27 May 2021 05:29:23 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:f:6020:3db3:bb86:bbaa:56ab]) by smtp.gmail.com with ESMTPSA id z3sm2917721wrq.42.2021.05.27.05.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 05:29:22 -0700 (PDT) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, odin@uged.al, cgroups@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH 0/2] schd/fair: fix stalled cfs_rq->tg_load_avg_contrib Date: Thu, 27 May 2021 14:29:14 +0200 Message-Id: <20210527122916.27683-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Odin reported some fairness problem between cgroup because of stalled value in cfs_rq->tg_load_avg_contrib: https://lkml.org/lkml/2021/5/18/566 2 problems generated this situation: -1st: After propagating load in the hierarchy, load_sum can be null whereas load_avg isn't so the cfs_rq is removed whereas it still contribute to th tg's load -2nd: cfs_rq->tg_load_avg_contrib was not always updated after significant changes like becoming null because cfs_rq had already been updated when propagating a child load. Vincent Guittot (2): sched/fair: keep load_avg and load_sum synced sched/fair: make sure to update tg contrib for blocked load kernel/sched/fair.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.17.1