Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 14:36:00 +0200
From:   Jessica Yu <jeyu@kernel.org>
To:     Yu Kuai <yukuai3@huawei.com>
Cc:     linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] module: fix compile error that sect_empty() is not
 defined in init_build_id()
Message-ID: <YK+SMJRDDCZqQJ26@p200300cbcf361a0029e37a38368d6727.dip0.t-ipconnect.de>
References: <20210527111453.195014-1-yukuai3@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210527111453.195014-1-yukuai3@huawei.com>
Precedence: bulk

+++ Yu Kuai [27/05/21 19:14 +0800]:
>If 'CONFIG_SYS' is not enabled while 'CONFIG_KALLSYMS' is enabled,
>fix following compile error:
>
>kernel/module.c:2805:8: error: implicit declaration of function ‘sect_empty’;
>did you mean ‘desc_empty’? [-Werror=implicit-function-declaration]
>
>Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Hi,

This has already been fixed in linux-next, see:

     https://lore.kernel.org/r/20210525105049.34804-1-cuibixuan@huawei.com

>---
> kernel/module.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index decf4601e943..173acb2aecc7 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -2794,7 +2794,8 @@ static void add_kallsyms(struct module *mod, const struct load_info *info)
> }
> #endif /* CONFIG_KALLSYMS */
>
>-#if IS_ENABLED(CONFIG_KALLSYMS) && IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
>+#if IS_ENABLED(CONFIG_SYSFS) && IS_ENABLED(CONFIG_KALLSYMS) &&\
>+	IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
> static void init_build_id(struct module *mod, const struct load_info *info)
> {
> 	const Elf_Shdr *sechdr;
>-- 
>2.25.4
>