Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp631348pxj; Thu, 27 May 2021 08:14:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0yOw1pEf+wo5WsubZcMk2toERZvbpSLkEZfdPUsaUMWcIHISlr5sMGM5QVL/xGWLxgGRO X-Received: by 2002:a92:1906:: with SMTP id 6mr3125199ilz.69.1622128446040; Thu, 27 May 2021 08:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622128446; cv=none; d=google.com; s=arc-20160816; b=XGgjVWONgUwsCKu4vPFxADuHgD1cxx4UaagIlHTswBi3xsuV5TkvQ2leV4r6E3NBy/ QBxakr+tdC6/d40G8kZqS3DrQqGZSDu/kJYJmMXm+0+U3yxa9FIuVKCu4J5oTPOzu9tJ e9URouUIVv/KCf4dqaOd+WRm08rj6GTKInMjzCSxeunzQJbgT0fSdR5YE6qC5gPQZyd8 pVCqfNcj6JdkLcG8BKEEWNzt3prIVbU4SaOQTYPNKRIhbRyfbN5WcrqK5dcDD12P7Gk4 RHz3UXXbmLT9INkJvrCD9Bw9b2S0Gb8+ZQgGs05jMHkX+XVjrOSYvYe1qK2mXjhT/C5b txUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=g49sK0BaWO1ncZGcxG01VvzKJZgdLBdmNCuIE34Ov5g=; b=WVBBAFl80Z8lUZPhEu90gUY42BipEaijDqtEuEkh9kxNFuqZfftqxTG8saa0NmK/8Q oME4qfXp9EbufgWj+K/TvrydGHWMylm5HKT+44LVi6Qb1EELOSXiSCl/tL5MkiUvKyjg Jc5QkUMyKrpwgiO8h5mcZq1e98ZQQFUPwrKDJSHI7TPk+iP5fLqd0P+vs7MQiCYryb1x LKBbIKCDBGw2GPhzr7qK6v4ERFnH+s94j1KH6mIWb6qPEzsdYr6KAKn4K8eEDpiNTcOe 8lUvNJTh5jtcv0O9WeWp+QBNDzvWUTlQo7KCMUJUwYpY7cKc3No3VQJPGEfcQEI/NFKl lI1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DtdTeZ+p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si2705037jaj.67.2021.05.27.08.13.50; Thu, 27 May 2021 08:14:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DtdTeZ+p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235371AbhE0IWD (ORCPT + 99 others); Thu, 27 May 2021 04:22:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235169AbhE0IWB (ORCPT ); Thu, 27 May 2021 04:22:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0585CC061574; Thu, 27 May 2021 01:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=g49sK0BaWO1ncZGcxG01VvzKJZgdLBdmNCuIE34Ov5g=; b=DtdTeZ+pckjlf8fAisbFEbNNno h7l5vQCH38rZ13QRrYXGddBmR+fHXScVzLgE4C2PhfZU9pQ7stDQN5O0luHUba9UIYekGYjoe4B8U XcBITWAa23uqAC+QQGgWFbrkgSeEcwEQ6dR9htF8RTangpxR+z1XwTYvAub7LaWKkGKi8ZB0DO6Zs wVY6xuaTBzNjjjxoqZf2j2pQpZcGQnu9sBnWuLQTeaRz57a57y97IDMHWwErtBvQEhcS45F0W/MvV y5if6Qr1sRji/4ib1oRK4MJ2LI8FH/EYnLtG3+2BsyJLNor19X0eE80ZZnPaQGwBKV6VFTG5deXFT HJ72TUWg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmBFH-005KEM-TH; Thu, 27 May 2021 08:20:00 +0000 Date: Thu, 27 May 2021 09:19:59 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 24/33] mm/swap: Add folio_rotate_reclaimable Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-25-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511214735.1836149-25-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 10:47:26PM +0100, Matthew Wilcox (Oracle) wrote: > Move the declaration into mm/internal.h and rename > rotate_reclaimable_page() to folio_rotate_reclaimable(). This eliminates > all five of the calls to compound_head() in this function, saving 75 bytes > at the cost of adding 14 bytes to its one caller, end_page_writeback(). > Net 61 bytes savings. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig