Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 14:41:08 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Kyle Tso <kyletso@google.com>
Cc:     heikki.krogerus@linux.intel.com, robh+dt@kernel.org,
        badhri@google.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with
 generic bit ops
Message-ID: <YK+TZOAlc6zYRE0v@kroah.com>
References: <20210527121029.583611-1-kyletso@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210527121029.583611-1-kyletso@google.com>
Precedence: bulk

On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote:
> BIT macro is not defined. Replace it with generic bit operations.
> 
> Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties")
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
> Changes since v1:
> - re-word the commit message
> 
>  include/dt-bindings/usb/pd.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> index fef3ef65967f..cb70b4ceedde 100644
> --- a/include/dt-bindings/usb/pd.h
> +++ b/include/dt-bindings/usb/pd.h
> @@ -163,10 +163,10 @@
>  #define UFP_VDO_VER1_2		2
>  
>  /* Device Capability */
> -#define DEV_USB2_CAPABLE	BIT(0)
> -#define DEV_USB2_BILLBOARD	BIT(1)
> -#define DEV_USB3_CAPABLE	BIT(2)
> -#define DEV_USB4_CAPABLE	BIT(3)
> +#define DEV_USB2_CAPABLE	(1 << 0)
> +#define DEV_USB2_BILLBOARD	(1 << 1)
> +#define DEV_USB3_CAPABLE	(1 << 2)
> +#define DEV_USB4_CAPABLE	(1 << 3)

Why not just include the proper .h file instead?