Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp690796pxj; Thu, 27 May 2021 09:27:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx24iht723mVgSBVB71CLxin6zmunaFVnTQhMv81Uc4uIIzdBkMZWtzSy+ovhlm2toIUD/d X-Received: by 2002:a50:bec1:: with SMTP id e1mr5129220edk.116.1622132823383; Thu, 27 May 2021 09:27:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622132823; cv=none; d=google.com; s=arc-20160816; b=xDMFbEn32ugAyUf6pgne7hRVdXapHs1J5X3qywwrj2C5slGm5OdduwjDErlpQThNKo 4kgjpV0zD89YTwPi+3G/kqXucw0KfEM6WX+nnmTGohBwkqd+NVWXU6sMNVf2EgRii+3n NrX9sftzZVEeI2GdWT+dX+0hz9ZTmDggomR9jA6CwMAL2fdjf6qDzfRtK9QZWJNv5BW0 1o+Af2Yht5tqOoMEvgOnQtXiux4TbMmIDJCNqrif9Jzfv7XUc/tGyQtjveE/vafz2HoM Xm2rdG+1tjO3lRHOP2BYTqxpkd53j/Lp/gWaStCJXap5/dcuRwv4Sd7m7ULsfA3yEhIq cTcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=vC1w+m2gFj0NBdSQr1ECSgW8iGeDGYvFDklf0Jp3cpo=; b=ncol1uGKE5bhnnzT3PUwYVXsoW745qDjCbdK0pltphhj7vV+/mpEKld6UX4WinPr8u vDpi7RX3lFPfmh0Rix8RfebxjKq86qH90MkMlJvrnplF/xcDEpzU013y4J8qB7xBhZ/Z BQiWiP/CarzMSvw8bGlOSyUX7UEweL4il4HO6Wqcwfj0EDoFzs4ciVObbhTsWkuFjiSn lcTUlkdcY0uzvhry4XxxCpKfxiu/7NG58s+ltiH/rqa25n12NgGoQhhstlx5XkKwlDeR mbuvfVwBosbDyDy3+ENImggpkC44N6ZAXADXe6e5Ko7QmP8JFdbtc2WSLP2jMifDLfiV 4vxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id va16si2574547ejb.325.2021.05.27.09.26.40; Thu, 27 May 2021 09:27:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236007AbhE0OEc (ORCPT + 99 others); Thu, 27 May 2021 10:04:32 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:41805 "EHLO mail-ed1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235119AbhE0OEa (ORCPT ); Thu, 27 May 2021 10:04:30 -0400 Received: by mail-ed1-f52.google.com with SMTP id j10so970834edw.8 for ; Thu, 27 May 2021 07:02:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vC1w+m2gFj0NBdSQr1ECSgW8iGeDGYvFDklf0Jp3cpo=; b=smPeXwPO4sOUrWcoW82WBai3BLIRnwH+9jKnNag6Pk1A5H3IasulcBN3oIvzvDT0ua Uv8gqDw8yR/hCacLP6HQfV0YWSdz+EPZIgkxFzETikv8kNJyzYhCbRn9qRFOkR6/yC/x 4TS0ahmdB+zQxXeIffOgTNVC23lwsdAFyeCTUJ7YvPHXiSVYKq20x80enBrBZArHHRau o5QIqn+ht7LxdMRlLPrZNJjt5cVkDftUQikKM+VTbg83WWpvvc3412pelyCLO2HrEjIk 912rOBB6EqnMPpudTYvuo0bQLuB20dE//GhB7eE+ICunFX4fygjfACZbn6FQ8eK7S5EO JmFQ== X-Gm-Message-State: AOAM533eD7t5N1jZ/UOrj+0jUurmQlXmRNn4j73xS1mqyCn9ptlYJtrM BUSwBggGZf1SFOuMjGq69LphCHtXn/nmSQ75PGA= X-Received: by 2002:a05:6402:190e:: with SMTP id e14mr4374302edz.146.1622124175283; Thu, 27 May 2021 07:02:55 -0700 (PDT) MIME-Version: 1.0 References: <20210523193259.26200-1-chang.seok.bae@intel.com> <20210523193259.26200-29-chang.seok.bae@intel.com> <1980c78b-d51b-c186-9179-f3c72692ad8a@kernel.org> In-Reply-To: From: Len Brown Date: Thu, 27 May 2021 10:02:43 -0400 Message-ID: Subject: Re: [PATCH v5 28/28] x86/fpu/amx: Clear the AMX state when appropriate To: Peter Zijlstra Cc: Dave Hansen , Andy Lutomirski , "Chang S. Bae" , Borislav Petkov , Thomas Gleixner , Ingo Molnar , X86 ML , "Brown, Len" , "Liu, Jing2" , "Ravi V. Shankar" , Linux Kernel Mailing List , "Chen, Tim C" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 7:56 AM Peter Zijlstra wrote: > Why can't this live in intel_idle.c ? You are right, and that looks reasonable. I was thinking we'd have to hack mwait_idle_with_hints() used by everybody, but we could clone intel_idle() above and have a plug in a tweaked version for AMX hardware. Len Brown, Intel Open Source Technology Center