Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp711953pxj; Thu, 27 May 2021 09:56:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJN9rHxmXQ42+b86HEyY0R1fImNEu2HYQbgQZLyBe76udUYXpH/y8yoTj1WwVRkNyl4Ibf X-Received: by 2002:a05:6402:10cc:: with SMTP id p12mr5297536edu.328.1622134609097; Thu, 27 May 2021 09:56:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622134609; cv=none; d=google.com; s=arc-20160816; b=fSVdf9PSAV5UHv94nzO9o1Q5b0mm9gjVSHuAPVVvqlNRDIM0f7Z5sMF0avwK8/o05/ ncmjkBcZ0rvNBzvtYIGQP1oHqId/AcA8s0qtoeY7VIqFE3t3+2C8cdBljYW3PZ4Dct5i UZ8ckrviS3cwN4v2N+pvEo/iKc6dCApNdqI0RRqJEr+9yoYJzCEKztweANnjhT4hW+BC gC2zehzNVAwASCggBgk280LHPLhnr+iLFEG9My2/ol23rGzLN+6C6d92fDuNgRgJ+b4+ LwSNryhrlYtvgeQ/OWjN+jaS0qNKCWBG0RV4ER2fqiKob7vMIeqfmIAaLvaFR0ijfxQa VY2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+jqOWEVHuZGkfA6MD8Z68F0r2FOE/7+7mfKMuVI/ccg=; b=M4slALf37JVJG4nqelFT4oLz2kttoaWD+oMbBOMts8XsXPbKGPnOMXQySkG6XjhmnA aDiwYCL3hK12GUMyzeI+JQ61aPMVzhDGZYI+BBCgUF1fUdmkzXkfY9Ga09GHAfmmcuVj l8e0TERg7HXqkDtGYPjo5kNogTok5IMn9AXYy2Zn3ST052hkba7tfzLjv8MUuP7Irq7r SVz6BTNPwmaoj+1LQywdbEm+JKtWIR3+ZcTtUABYBynr8QtzFkUTOGl7daj6wYuSHVbS y3WwjmzHEa7ZsQd5LOkbySJcjF+aELAt3NZKSSsxiwNaub4n5MLYRxrvq5r/GQie578/ 9Rcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cJoEDb4C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gw16si2564215ejb.250.2021.05.27.09.56.21; Thu, 27 May 2021 09:56:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cJoEDb4C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235288AbhE0Oxj (ORCPT + 99 others); Thu, 27 May 2021 10:53:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235254AbhE0Oxj (ORCPT ); Thu, 27 May 2021 10:53:39 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C8CDC061574 for ; Thu, 27 May 2021 07:52:03 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id j10so450623lfb.12 for ; Thu, 27 May 2021 07:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+jqOWEVHuZGkfA6MD8Z68F0r2FOE/7+7mfKMuVI/ccg=; b=cJoEDb4CQ/mHG5hJsPhdH+w76PE7kgmJxWhbPuRqPqvqTaEib07YsiwAXxRgaLuM0+ /bKteq6nUzAEouzLWj9/mJJCmYoGxyisr2QDmn5KYOcDs0m4/dwPxdSsczE7qsZsc8K0 U3oAGI1C8St8Aalf/NABCefTVRYf6G3kYRaUeWDu8G5pLRxzT0Hv4U9yWMI8kOE8vZd5 VGU7U9oSdwVl8I2Qv6PmTHaVqzWJm7tjB3YYFJkOqzD3Nrz6poXMtRbx+ICPPy+9zPsA TjotsHzY9phpNO1B2bvHVe22wACZlNtJBsBnufuS3agHuoZ3BDjmLeQSH5JT0ryyChOF MpPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+jqOWEVHuZGkfA6MD8Z68F0r2FOE/7+7mfKMuVI/ccg=; b=nm6QWCrC3/qljYTktbgvRCFjhDlak0kAtz6LvRw7nUxP0q0Hc4QhRNhB1HrGxzKPfF lxd2P6+5zjVRfYCL74oP/DI+eORHHYjZcxMYRon7k+YXfxsHzwDo6HZRglizVyn+g3PP fsbtKGP97wC/khzDV0gHoMqWG8h6lScFB7a7Fwxol9K7ZXbwEPj3X+H4HQXF6hVb2LfT c8Ev0rtnk31tAV4F6lL/ilyRREvj36OPO9GQx0BIDXqbiXlaZdpcM8Gi4jR7PtKzqKWD lVPsvy5du0tlSi6F1w7xE85vIoph4yaOOwLWf4TFRANONtkK32aOVSWMSmspnYQxho6N 5Gcg== X-Gm-Message-State: AOAM532XVsPyMQOH8PluMVwGI0I4SZiR/JzP8NLjXsvHGo7mrw8ejrsL ie2WQrxDcRuSipm4SQp1uenB6jV6qMBu8bMNbp2oRg== X-Received: by 2002:a05:6512:1185:: with SMTP id g5mr2652587lfr.586.1622127121750; Thu, 27 May 2021 07:52:01 -0700 (PDT) MIME-Version: 1.0 References: <20210519162409.3755679-1-fparent@baylibre.com> <20210519162409.3755679-2-fparent@baylibre.com> In-Reply-To: <20210519162409.3755679-2-fparent@baylibre.com> From: Linus Walleij Date: Thu, 27 May 2021 16:51:50 +0200 Message-ID: Subject: Re: [PATCH 2/3] pinctrl: mediatek: don't hardcode mode encoding in common code To: Fabien Parent Cc: Sean Wang , Matthias Brugger , mkorpershoek@baylibre.com, "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" , linux-kernel , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 6:24 PM Fabien Parent wrote: > MT8365 encode the pins mode differently than other > MTK pinctrl drivers that use the PINCTRL_MTK common code. > > Add 3 new fields in mtk_pinctrl_devdata in order to store how > pin modes are encoded into the register. At the > same time update all the pinctrl driver that depends on > CONFIG_PINCTRL_MTK. > > Signed-off-by: Fabien Parent Patch applied. Yours, Linus Walleij