Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   ebiederm@xmission.com (Eric W. Biederman)
To:     Alexey Gladkov <legion@kernel.org>
Cc:     Yang Yingliang <yangyingliang@huawei.com>,
        linux-kernel@vger.kernel.org
References: <20210526143805.2549649-1-yangyingliang@huawei.com>
        <m1sg29kuxo.fsf@fess.ebiederm.org>
        <20210527085613.7nnnh3ocwedvcntz@example.org>
Date:   Thu, 27 May 2021 11:10:27 -0500
In-Reply-To: <20210527085613.7nnnh3ocwedvcntz@example.org> (Alexey Gladkov's
        message of "Thu, 27 May 2021 10:56:13 +0200")
Message-ID: <m1mtsgkvik.fsf@fess.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH -next] cred: add missing return error code when set_cred_ucounts() failed
Precedence: bulk

Alexey Gladkov <legion@kernel.org> writes:

> On Wed, May 26, 2021 at 05:10:43PM -0500, Eric W. Biederman wrote:
>> Yang Yingliang <yangyingliang@huawei.com> writes:
>> 
>> > If set_cred_ucounts() failed, we need return the error code.
>> 
>> Alex how does this look to you?
>> 
>> This is showing up now as I have finally dropped the code in linux-next
>> and other people are looking at it.
>> 
>> At a quick fix looks correct to me.
>
> Yes, this is the right fix. I miss it.


Can I have your Acked-by or Reviewed-by.
Thank you.

>> > Fixes: 905ae01c4ae2 ("Add a reference to ucounts for each cred")
>> > Reported-by: Hulk Robot <hulkci@huawei.com>
>> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> > ---
>> >  kernel/cred.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/kernel/cred.c b/kernel/cred.c
>> > index db7c46bf36e5..e6fd2b3fc31f 100644
>> > --- a/kernel/cred.c
>> > +++ b/kernel/cred.c
>> > @@ -372,7 +372,8 @@ int copy_creds(struct task_struct *p, unsigned long clone_flags)
>> >  		ret = create_user_ns(new);
>> >  		if (ret < 0)
>> >  			goto error_put;
>> > -		if (set_cred_ucounts(new) < 0)
>> > +		ret = set_cred_ucounts(new);
>> > +		if (ret < 0)
>> >  			goto error_put;
>> >  	}
>> 

Eric