Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp821764pxj; Thu, 27 May 2021 12:26:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx60wJdwdr8cRZaOlCQv8BhOU0CbkyXFC2lxa/CYdV1HJojm2wFlu4vEaxrrRnTaw7FEeGI X-Received: by 2002:a17:906:7f06:: with SMTP id d6mr5566316ejr.189.1622143582269; Thu, 27 May 2021 12:26:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622143582; cv=none; d=google.com; s=arc-20160816; b=DXy37/l5BgKcvjGu7aOeX28jZt6Jw4wczg9x/EMcrStW+TqiNHVPMnc3MyzCZe4N0C Jg3zOy6k8j+gF0X6sh6Z110JCq5Aa6oRa+w05oo1JxrMsoFeXtPVTvwY0U86WetaxRUO mkatxOeSkL3MLt5ZZpaEFP+dhSS0L/Tb0loqKFC6pIhPybwHiM75W8vBC/lp4N4e2d2c SIqjmyea69wz/WdWXIyPPNHGqAiQhBGiI9aXpTnCvl4PC7sGLctCC/W4iTSRMX317Imm CB4H7wedGsqqcNBtt5rxCGwFin+uok36Tn4Vy2BzEPHZ88yoxU7HU0lWka9NrVFM/Ic6 5cBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=HdgeWXm2oqrmiwWhjn2rbiLTCJCom2GcNMlSHtMaWJw=; b=p2o1V7Q+vC5UYu9J5a+TDETu+mHEml4Ev+QSbsKGHnCGD1zykFFO3NxbK+WRP8e/eO Ka7a7ootFVeZADtsPW4OhsaNV66rPMgav8i9Ru7bklPwXkM19jF0msOErtQ32kCOqvRz 8JnmxqGYqYFBE0yeBKqZLk6iWaXQvSYqRxlDspPeTwlqz4/4BjqoCK4h6k62mAuys0ww mnaeD0Wgg4fCsqRq95wKbpbyn2Fb36YAdpiXrGJRgvvLYXMjGUdevh9NMzKMCPohlw04 VkoUYo7ALdv0Clu1E02E0XOb+H+SDnDsZS6cYyOzt3XrXJi5o+mUPf3wHmfJrqX6znet cWjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwO6wtXj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl4si2595388ejb.17.2021.05.27.12.25.55; Thu, 27 May 2021 12:26:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwO6wtXj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234186AbhE0TXT (ORCPT + 99 others); Thu, 27 May 2021 15:23:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:51310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbhE0TXT (ORCPT ); Thu, 27 May 2021 15:23:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F070600D4; Thu, 27 May 2021 19:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622143305; bh=HdgeWXm2oqrmiwWhjn2rbiLTCJCom2GcNMlSHtMaWJw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VwO6wtXjA9AHg22s/NQBeHFBS6q2JvP9EKYdt3vKWL/LylDBzxCChdeHNPfq1BGLb vDku4Pks/mR4ZiEkOHzFnfja/G+zG9wf/bGcrTTVWWrqUMHOs2B6URKCwo2GJw5wwk RoCfwtjDJwivS4ye5H10ewVHdMRrzY8Sj5eyK2xODmAlzVLZfrYhNqJSbAId2VdYMJ M9Az7ylKrfKQSZrQ7jY/Ew+qPUBlvTDmkPpP2+MwZAzazKNWrHzMMKriBEankYVeTC 1v2jn1XrY0FXexoFfP4MwgwIeIuTT6cp6MqVbcan5mVGdRBFSq0invxtQ62gKUwy4F 2poju+IUgOM/A== Date: Thu, 27 May 2021 12:21:44 -0700 From: Jakub Kicinski To: Joakim Zhang Cc: davem@davemloft.net, frieder.schrempf@kontron.de, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH V1 net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations Message-ID: <20210527122144.2f260a26@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20210527120722.16965-3-qiangqing.zhang@nxp.com> References: <20210527120722.16965-1-qiangqing.zhang@nxp.com> <20210527120722.16965-3-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 May 2021 20:07:22 +0800 Joakim Zhang wrote: > +u16 fec_enet_get_raw_vlan_tci(struct sk_buff *skb) Let's perhaps wait for the testing with a repost but both functions added in this patch need to be static.