Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] afs: fix no return statement in function returning
 non-void
From:   Randy Dunlap <rdunlap@infradead.org>
To:     David Howells <dhowells@redhat.com>,
        Zheng Zengkai <zhengzengkai@huawei.com>
Cc:     linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
        huawei.libin@huawei.com
References: <20210327121624.194639-1-zhengzengkai@huawei.com>
 <6575.1617890815@warthog.procyon.org.uk>
 <02f8940c-e1af-fffa-8bb3-3bfa96bfafa9@infradead.org>
Message-ID: <2bc0f5fd-2519-7b53-7535-99054607ea4c@infradead.org>
Date:   Thu, 27 May 2021 12:48:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <02f8940c-e1af-fffa-8bb3-3bfa96bfafa9@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/19/21 3:31 PM, Randy Dunlap wrote:
> On 4/8/21 7:06 AM, David Howells wrote:
>> Zheng Zengkai <zhengzengkai@huawei.com> wrote:
>>
>>>  static int afs_dir_set_page_dirty(struct page *page)
>>>  {
>>>  	BUG(); /* This should never happen. */
>>> +	return 0;
>>>  }
>>
>> That shouldn't be necessary.  BUG() should be marked as 'no return' to the
>> compiler.  What arch and compiler are you using?
> 
> How do mark a #define BUG() as __noreturn?
> 
> Several arch-es use #define for BUG() instead of using a function.

Hi David,

So you are counting of BUG() being a function and not a macro?

Doesn't seem like a good idea.

-- 
~Randy