Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 21:59:28 +0200
From:   Grzegorz Szymaszek <gszymaszek@short.pl>
Cc:     Grzegorz Szymaszek <gszymaszek@short.pl>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Marcin =?utf-8?Q?S=C5=82oniewski?= <marcin.sloniewski@gmail.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: fix stm32mp157c-odyssey card detect pin
Message-ID: <YK/6IHCBdIU3UBqs@nx64de-df6d00>
References: <YHH9+Xrn5Quge4Jt@nx64de-df6d00>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YHH9+Xrn5Quge4Jt@nx64de-df6d00>
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

On Sat, Apr 10, 2021 at 09:35:21PM +0200, Grzegorz Szymaszek wrote:
> The microSD card detect pin is physically connected to the MPU pin PI3.
> The Device Tree configuration of the card detect pin was wrong—it was
> set to pin PB7 instead. If such configuration was used, the kernel would
> hang on “Waiting for root device” when booting from a microSD card.
> 
> Signed-off-by: Grzegorz Szymaszek <gszymaszek@short.pl>
> ---
>  arch/arm/boot/dts/stm32mp157c-odyssey.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp157c-odyssey.dts b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> index a7ffec8f1516..be1dd5e9e744 100644
> --- a/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> @@ -64,7 +64,7 @@ &sdmmc1 {
>  	pinctrl-0 = <&sdmmc1_b4_pins_a>;
>  	pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
>  	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> -	cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> +	cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
>  	disable-wp;
>  	st,neg-edge;
>  	bus-width = <4>;
> -- 
> 2.30.2
> 

A gentle ping. FWIW, there was another patch that would deal with the
same issue:
<https://st-md-mailman.stormreply.com/pipermail/linux-stm32/2021-April/011132.html>,
but it took the more radical approach of of replacing cd-gpios with
broken-cd.

-- 
Grzegorz