Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp875185pxj; Thu, 27 May 2021 13:48:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt9NPEuq0goyJ3dR2ubjwaOmde5k9w0ABx5C+Bod50ajHyfEV0wbMYudQlO+e3tnqZ3+ns X-Received: by 2002:a05:6e02:1c87:: with SMTP id w7mr4635822ill.25.1622148514392; Thu, 27 May 2021 13:48:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622148514; cv=none; d=google.com; s=arc-20160816; b=OZEAe6K4O6S6FnWq/l+4Hys+SuL99zBECUV98uCaFsfnRA7VTMB18EWPgzI+HXJzlA YaLcHPm31E/JZw2ptD5vWYA6kmXZdyqPGR0PDxRXAy8NCRBgLw/KddY2P3D9RKizTAGU yZ7Eu7A3/TfIynwDJxYij66X8y7uVQ8IEcuqq5fD9jgAlOv0yxc5ZXDGb6d1/DlMkfQO hw5To+DZju7xfXdiBpKakN07V9mYRrd1aDc62fyrtOPy5iigNdjWbJSKnI8GKp9n+ycp nn3Sw2nxNDKwlbhDA7OsJazTpFj4aKrVldmTGuxp1BDY+9w06v/I6duSybkq9QW45fOV IC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=PuHDRg7H8xpar/rHUteFLoS19nnwYu+rljG+ADldRUQ=; b=uQmiUjQ8/a/D0rXFQmAd4QdhalmRyKq1tEYLP1mAgUc9+6CZtSlkatDY2L15RyZY4/ bHpAytAXHxkFiDsOnVjNzYY7TNSzolGtnr2nYOf9kg5eds6RH4RBPf3/+erqiGgNyGIQ 5CRkMhKUu6p1v1LNiTRbXNnzgfD2NgrnRl6DQ2PPAWSnvdF5lfadnCCQ/LQzCaU9M1fm K4ZFLxSsnM/0GBsgg4qEruYrBxRYt/KTpeMKPaziOr7Exq991ekxRvcYTu0SIpFCMov9 ItTgqJFLaquFBmaLx7uzqMVOEg7/AgalwbNuEe0oqcM/wfQaJInYtSXPbTusqYfWu2La vkRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p26si3973990jal.111.2021.05.27.13.48.16; Thu, 27 May 2021 13:48:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233969AbhE0LlC (ORCPT + 99 others); Thu, 27 May 2021 07:41:02 -0400 Received: from tux.runtux.com ([176.9.82.136]:44174 "EHLO tux.runtux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233044AbhE0LlA (ORCPT ); Thu, 27 May 2021 07:41:00 -0400 Received: from localhost (localhost [127.0.0.1]) by tux.runtux.com (Postfix) with ESMTP id C31B96F051; Thu, 27 May 2021 13:39:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at tux.runtux.com Received: from tux.runtux.com ([127.0.0.1]) by localhost (tux2.runtux.com [127.0.0.1]) (amavisd-new, port 10026) with LMTP id KdnsqXt3na9a; Thu, 27 May 2021 13:39:22 +0200 (CEST) Received: from bee.priv.zoo (62-99-217-90.static.upcbusiness.at [62.99.217.90]) (Authenticated sender: postmaster@runtux.com) by tux.runtux.com (Postfix) with ESMTPSA id AC2A76F04A; Thu, 27 May 2021 13:39:21 +0200 (CEST) Received: by bee.priv.zoo (Postfix, from userid 1002) id C8C8046E; Thu, 27 May 2021 13:39:20 +0200 (CEST) Date: Thu, 27 May 2021 13:39:20 +0200 From: Ralf Schlatterbeck To: Mark Brown Cc: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Mirko Vogt Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Message-ID: <20210527113920.ncpzrpst2d6rij3t@runtux.com> References: <20210520100656.rgkdexdvrddt3upy@runtux.com> <20210521173011.1c602682@slackpad.fritz.box> <20210521201913.2gapcmrzynxekro7@runtux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ray: beware User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 03:35:51PM +0100, Mark Brown wrote: > On Fri, May 21, 2021 at 10:19:13PM +0200, Ralf Schlatterbeck wrote: > > From: Mirko Vogt > > > > The current sun6i SPI implementation initializes the transfer too early, > > resulting in SCK going high before the transfer. When using an additional > > (gpio) chipselect with sun6i, the chipselect is asserted at a time when > > clock is high, making the SPI transfer fail. > > Please don't send new patches in reply to old threads, this makes > it hard to follow what is going on and creates confusion as to > what the current version of things is and means things can easily > get missed if the earlier thread gets discarded - this goes along > with the thing Andre mentioned about flagging the version of the > patch in the subject line. OK, let me know if I should repost in new thread with increased version number in the subject. Thanks, Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting www: www.runtux.com Reichergasse 131, A-3411 Weidling email: office@runtux.com