Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 14:00:38 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     eli.billauer@gmail.com
Cc:     arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] char: xillybus: Add driver for XillyUSB (Xillybus
 variant for USB)
Message-ID: <YK+J5oy1qH6dWAmG@kroah.com>
References: <20210526100311.56327-1-eli.billauer@gmail.com>
 <20210526100311.56327-3-eli.billauer@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210526100311.56327-3-eli.billauer@gmail.com>
Precedence: bulk

On Wed, May 26, 2021 at 01:03:11PM +0300, eli.billauer@gmail.com wrote:
> From: Eli Billauer <eli.billauer@gmail.com>
> 
> The XillyUSB driver is the USB variant for the Xillybus FPGA IP core.
> Even though it presents a nearly identical API on the FPGA and host,
> it's almost a complete rewrite of the driver: The framework for exchanging
> data on a USB bus is fundamentally different from doing the same with a
> PCIe interface, which leaves very little in common between the existing
> driver and the new one for XillyUSB.
> 
> Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
> ---
> 
> Notes:
>     Changelog:
>     
>     v5:
>       - Move xillyusb.c back from staging to char/xillybus/
>       - Turn previously lockless FIFO into one relying on a lock
>       - Set driver's soft_unbind flag, so that the device is notified when the
>         driver is unloaded + due changes for killing URBs as required
>       - Some refactoring of locks for better granularity
>       - Avoid using pr_err and pr_warn, replace with dev_* counterparts
>       - Bump MODULE_VERSION to 1.1

Nit, you should just remove the MODULE_VERSION() stuff, it makes no
sense once it is in the kernel tree to have them as they then mean
nothing.

But that can be an add-on patch, let me review these...