Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210527032948.3730953-1-keescook@chromium.org>
In-Reply-To: <20210527032948.3730953-1-keescook@chromium.org>
From:   Rodrigo Campos <rodrigo@kinvolk.io>
Date:   Thu, 27 May 2021 14:45:26 +0200
Message-ID: <CACaBj2atO=2aAyK+BO5MPS0B3CQNwc98CSHiuy8X2wvkdvJNDQ@mail.gmail.com>
Subject: Re: [PATCH] selftests/seccomp: More closely track fds being assigned
To:     Kees Cook <keescook@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Sargun Dhillon <sargun@sargun.me>, containers@lists.linux.dev,
        Tycho Andersen <tycho@tycho.pizza>,
        =?UTF-8?Q?Mauricio_V=C3=A1squez_Bernal?= <mauricio@kinvolk.io>,
        Giuseppe Scrivano <gscrivan@redhat.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@linux.microsoft.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Will Drewry <wad@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 27, 2021 at 5:29 AM Kees Cook <keescook@chromium.org> wrote:
>
> Since the open fds might not always start at "4" (especially when
> running under kselftest, etc), start counting from the first assigned
> fd, rather than using the more permissive EXPECT_GE(fd, 0).
>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Nice cleanup, thanks! Just in case, tested it here, works fine. Feel
free to add:

Reviewed-by: Rodrigo Campos <rodrigo@kinvolk.io>

I can improve the selftest to test the new addfd flag we just added
also in combination existing flags (like setting the fd number to
use), and maybe also split the big chunk test, if you think that is
valuable.

Best,
Rodrigo