Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 09:51:35 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Jeremy Linton <jeremy.linton@arm.com>
Cc:     coresight@lists.linaro.org, suzuki.poulose@arm.com,
        mike.leach@linaro.org, leo.yan@linaro.org,
        alexander.shishkin@linux.intel.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: Propagate symlink failure
Message-ID: <20210527155135.GA1297106@xps15>
References: <20210526204042.2681700-1-jeremy.linton@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210526204042.2681700-1-jeremy.linton@arm.com>
Precedence: bulk

On Wed, May 26, 2021 at 03:40:42PM -0500, Jeremy Linton wrote:
> If the symlink is unable to be created, the driver goes
> ahead and continues device creation. Instead lets propagate
> the failure, and fail the probe.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 6c68d34d956e..2dc4b0110442 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev)
>  		}
>  	}
>  
> -	return 0;
> +	return ret;

I have applied your patch.

Thanks,
Mathieu

>  }
>  
>  static int coresight_remove_match(struct device *dev, void *data)
> -- 
> 2.31.1
>