Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210405202857.1265308-1-gwendal@google.com>
In-Reply-To: <20210405202857.1265308-1-gwendal@google.com>
From:   Gwendal Grignou <gwendal@chromium.org>
Date:   Thu, 27 May 2021 14:01:34 -0700
Message-ID: <CAPUE2uvZzXUoG+Fr7c3q0ysMUz0eb36PrdknG37FkG1v2h7zUg@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute
 after sensors are found
To:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Gwendal Grignou <gwendal@google.com>,
        Dmitry Torokhov <dtor@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

[+dtor]
Is this change acceptable? I was worried it could break when
asynchronous probing is used [https://lwn.net/Articles/629895/], but
since all probes are deferred in a single thread, it is safe.
Gwendal.


Gwendal.

On Mon, Apr 5, 2021 at 1:29 PM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> Attribute "kb_wake_angle" in /sys/<cros_ec hw path>/chromeos/cros_ec,
> used to set at which angle the embedded controller must wake up the
> host, is only set when there is at least 2 accelerometers in the
> chromebook.
>
> The detection of these sensors is done in cros_ec_sensorhub, driver that
> can be probed after the cros_ec_sysfs driver that sets the attribute.
> Therefore, we need to upgrade the cros_ec sysfs groups in the sensorhub
> probe routine.
>
> The first patch cleans up cros_ec_sysfs by using .dev_groups driver
> field, the second patch fixes the problem.
>
> Gwendal Grignou (2):
>   platform/chrome: Use dev_groups to set device sysfs attributes
>   platform/chrome: Update cros_ec sysfs attributes on sensors discovery
>
>  drivers/platform/chrome/cros_ec_sensorhub.c |  5 ++++-
>  drivers/platform/chrome/cros_ec_sysfs.c     | 22 +++++++--------------
>  include/linux/platform_data/cros_ec_proto.h |  2 ++
>  3 files changed, 13 insertions(+), 16 deletions(-)
>
> --
> 2.31.0.208.g409f899ff0-goog
>