Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp48722pxj; Thu, 27 May 2021 20:58:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz32aBsLyrRUcSLUytCAKFSxTqn0H0frSDzWz61FQJaQBPKvRhPNSvfiGcn+mfbvkVLfhuS X-Received: by 2002:a5e:8519:: with SMTP id i25mr5505114ioj.199.1622174307031; Thu, 27 May 2021 20:58:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622174307; cv=none; d=google.com; s=arc-20160816; b=n8g1UnkZzrgxo97D+DMz3Zc/pP4V7XGUmEBW7uhgsgXI62K+94DD02JW8KYGHg4xxX sj7rzrViGZzLO2/tM4CtxrA9D/mLWaCDI/B06Ur5/nQV4dqZHOX+dytJw8T14g/T0uzE VyYTM3/Ck2Q3rxC5b0+7ZxsCuDa0a1ZrnpMliZmlUaHqgvwC086cyxtwyKGc9ppJpRTE oNZmCcQwbyxtJ93YJiIR7RclmxUyFrkE46GjqGGOaH4ywhkek4ick5le9DVPwJjwmur0 M0VPfdwBktN8HXIn+m7ztFcIbkQCwP3OJTLZhYqwzbvRuiVt3OgVU3JiBZja4NkEg0Gi Xeew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=95QELRGt3WnpgXBZfUKFp2QKTKq0EmitnNeYW0Z4b00=; b=TuDX4K6im4sLenmppzHuBx0MTJx94VFE2Nq7hTzJ8cBVGf24xryrMcUyBAmNT7aw6Y 2Z/qybAankQaX1YJulqOy7YQYyQHgmKf1DlnucUUXYlpRVxUHHD81gzdevejhMm7YRdQ 5HpNZoEIAKWlnmXNCBsxOebCDcgjWswTObRkThpmJb2+mzvwIq/n6/xIXCZPU2AwmuoU wF8NcbfMpRDfoQxlOgMIE/43XslMeixbD2Tt4CJioYsLTtCcEAc5VP7yUdA4RpKPEPGJ aiFcVPg7F6y+QHU37RR1ARFmW5ynwSAX23j5VDOWzLNUiXToJOeDoPWYNQUEllvf9Q8c hItw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JHzOGH3R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r18si4444992ilm.131.2021.05.27.20.58.13; Thu, 27 May 2021 20:58:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JHzOGH3R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbhE1Alz (ORCPT + 99 others); Thu, 27 May 2021 20:41:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhE1Alz (ORCPT ); Thu, 27 May 2021 20:41:55 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F614C061760 for ; Thu, 27 May 2021 17:40:20 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id a2so2746885lfc.9 for ; Thu, 27 May 2021 17:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95QELRGt3WnpgXBZfUKFp2QKTKq0EmitnNeYW0Z4b00=; b=JHzOGH3Rc3QzKK/Ko1E2bnUdXa+dF2SXbNLvEC4WOMB3ME0NjEkkXjIOu3vhgBjmSm xAoBuWZf2Y6gaqTX/uwq1QXNRyDtR5Z5gYvpan34I6clp7Y8269dChWGB1qbHrdX17jr /trAilTK5HE8H4ZDJlTAMIy1g6uo7GsCv18lyPxl4t2yXjZtlUzMx3q6MNAqs+33rrJA tKUCWcKbHoZEtZf4z8/P0bKU1AJ7nqUh8r9SWzWCXhSMfZP6/CFK66voUTGP2UGzRSNq iqVdcHJYDaIgzmJiBuBdesk7XwXASckGaB/X7onHSIyusXxH7q3+ds6lU5Jj9mDUUD40 DIYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95QELRGt3WnpgXBZfUKFp2QKTKq0EmitnNeYW0Z4b00=; b=CnjUR7v/LpVbHHFWMplQGuVlH8tyRWFfMTMfYH9IG4NMPRXKCP7FwiaHlBQP4pH6on /uqzpqDPC4sNSEfMD4k9b5okQ8WcorUA0NyORGCQorD2kRdJMT66mwxHQUcJ6NSqU4Ta TIAsTmVcwNLYRVBh+Kc13Q8P3cSB/6qDQnJVlsbpqdL3BxVH1MOROv+skfhE6UyN4rMc Ia+f4RiOUu5xBR3pR77ehWaonVXb9rnB5yHJKOuy80n1J/VQS3Ofa3RYdMyC5VsHthv6 mX/Wm6d4prNksIpXkS31U0ujN84kRDf4NkTk8f3qV/9TUs9SdsUHty2Y4kAbz5XKvK0u fGqg== X-Gm-Message-State: AOAM532yVa526/qMwo6BvvwgR9rF16DQU9QOtCZXvbVwKe4iodKcfdeF 6uWhJjXsXiUJg3cBFdNqa/3SWzJvOrMLEGPlLSaxsNV01n4= X-Received: by 2002:ac2:47e6:: with SMTP id b6mr3928339lfp.649.1622162418755; Thu, 27 May 2021 17:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20210525183518.63149-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210525183518.63149-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Fri, 28 May 2021 02:40:07 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] gpiolib: Split fastpath array to two To: Andy Shevchenko Cc: Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-kernel , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 8:35 PM Andy Shevchenko wrote: > Split fastpath array to two, i.e. for mask and for bits. > At the same time declare them as bitmaps. > > This makes code better to read and gives a clue about use of > bitmap API. > > Signed-off-by: Andy Shevchenko Excellent code! Reviewed-by: Linus Walleij Yours, Linus Walleij