Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp98097pxj; Thu, 27 May 2021 22:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQCpb8RNpjZsF1olUvufYwFzW7qQmroNoAnqJ7KDhMw1lCKEqwSn6GI8zgpEeyD+/ORG/h X-Received: by 2002:a92:1909:: with SMTP id 9mr5881927ilz.229.1622180096396; Thu, 27 May 2021 22:34:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622180096; cv=none; d=google.com; s=arc-20160816; b=mL54Eav2cO49RvhLzEzC2RMxbqg3XdDcy0uox4pVJM6chGGeo8dQnjy/3u3BZlM8UR 3WZkQq5UsMZe5srZclpuBbgBN5cFeAMalgXAQXSgy40ii/fk2Mf8e8ELqR+NOfrhFDkM ipxeWdfdPYlx1zatejzTOhAmSBzq7qLsZxmTwhXDGLXz4f+tIrm35SbenkNw5uQkgsxO 7eJkvukn2xpEW481OkFQBoShPnx8va4Zw/QBEKamvpwXLGUNi/p0ElcvnijNjLjs1+Oz 7m0kFcBh2DioHIDJTzJ45LMHUtoAP/65HLFtr8bUiUZGZxdh8bnprY6/5IBaT47lHIrD 7TKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=2zDSOeeqBsjSedBU7KQPMsD/IqrkmF0FS2E8UijFOtM=; b=TwsT6lLDysxxxu8CR1TiqgvVM2BcEElt421kP8Q5q05fzsty8qy+SZUjSD8mPJUHsT b9qwXyqHbxvvUtRWMRWKju1oWGDyogBlTEFlB4KhnDW3r8S5dQs/Ggx/s7YyvCaJC1+l z/65mPgBjJaPWbW/SVH73IY+Cj//Ugh/Eth29D6UbCupYbM0dTDfdejOHjFPsQlsO9Lt 0dZFG/1kooXc+UmrNPlA89QKX0pWd/NG74GLfAqVLgGv/rSYzaadoGDd9YlKUZwCaAnw r74Uw70y1kTauNC2wZ7PXhOO/ZiitLbYl9SampqQ1KprFU5NavVKZTvK5lbH5d/BIh2C WyiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si4502437ilp.43.2021.05.27.22.34.42; Thu, 27 May 2021 22:34:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbhE1Bvp (ORCPT + 99 others); Thu, 27 May 2021 21:51:45 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2506 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235596AbhE1Bvk (ORCPT ); Thu, 27 May 2021 21:51:40 -0400 Received: from dggeml755-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FrncW3L4NzYqbF; Fri, 28 May 2021 09:47:23 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggeml755-chm.china.huawei.com (10.1.199.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 09:50:03 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 09:50:02 +0800 From: YueHaibing To: , , , CC: , , YueHaibing Subject: [PATCH] perf: xgene_pmu: use DEVICE_ATTR_RO macro Date: Fri, 28 May 2021 09:49:40 +0800 Message-ID: <20210528014940.4184-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing --- drivers/perf/xgene_pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index ffe3bdeec845..62d942534a6b 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@ -604,15 +604,15 @@ static const struct attribute_group mc_pmu_v3_events_attr_group = { /* * sysfs cpumask attributes */ -static ssize_t xgene_pmu_cpumask_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t cpumask_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct xgene_pmu_dev *pmu_dev = to_pmu_dev(dev_get_drvdata(dev)); return cpumap_print_to_pagebuf(true, buf, &pmu_dev->parent->cpu); } -static DEVICE_ATTR(cpumask, S_IRUGO, xgene_pmu_cpumask_show, NULL); +static DEVICE_ATTR_RO(cpumask); static struct attribute *xgene_pmu_cpumask_attrs[] = { &dev_attr_cpumask.attr, -- 2.17.1