Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp103821pxj; Thu, 27 May 2021 22:46:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJQBzddxAcXfoaDjQ01XWhdut6EUgd+mcj7ejG5/FTX9m2tEqejK4ZkYUR3GMYSzSKOpGw X-Received: by 2002:a02:c652:: with SMTP id k18mr7115153jan.105.1622180789232; Thu, 27 May 2021 22:46:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622180789; cv=none; d=google.com; s=arc-20160816; b=cCXNcIFEjwvpJTuG8KxeUP7+Px5r6s4tkLRVPR22c8AkqiowUstf78KIWNYm1zdPJ6 yw8M5xrWfgOHH45jW4JxvU/9dEIa0u83dDN0+IJ1YgP22QvlQzCXm31xIZHh6XfZ1w0A 1wo0Ryro6tGmdbYqz3mCl1cXqRyfsbWnyB8qtveGPAl+WLMy2DHqn9swlIxeFqLe5RQc YJKvWfxR2vhd2X2dNklpJ3Ax4bCJRMLopL5TYCSjfIrvnjm27qpPWzXPTjcmDi3sHoYY krQsBNMQWdascnlAZ9RKVVG9UwpiMgai7VCHSo3yBuux95qFV+lbl8R0xe1O9RjLTFDx u5RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Eiz/iz4MNv20NPEu6im0tYTEHn2TUa/MV9TnB6Igv4I=; b=fyqUefN3KrFQmDU0h4u9hEesj9lZ5MILdMNlPgh0MDRi+a9sespEzCYVt/Mzd60VVx jMnHhLWQBYPAjBCsZEqzN6bXdqqrbR940MEVXbKKp8QZ51eLd/S6mfqqJuCiGW1+Aa16 3WgUyjbhTLzN6AHivzJW1Jd/1kTKTd9IPdxdq3dqpOe73b26J5HSUMl8zZVWX7wShOO8 DY45rLI5BZ1AJ36Q/dof7fdUf4mSldJ95dfXUrk7u9lSff8EB02RfHEB79EjcjB/NePc SAJ/d2WPVpaoBw1QaWYSTt+YnpMveYavt/6CtovybyqFvBcwK8J0h/nWh+cpvcu8Nyta Gx6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a2si4502437ilp.43.2021.05.27.22.46.15; Thu, 27 May 2021 22:46:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235937AbhE1CJo (ORCPT + 99 others); Thu, 27 May 2021 22:09:44 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2068 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234834AbhE1CJn (ORCPT ); Thu, 27 May 2021 22:09:43 -0400 Received: from dggemx753-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Frnz74bpKzWp7w; Fri, 28 May 2021 10:03:31 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 28 May 2021 10:08:07 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: logging neatening To: Joe Perches , Jaegeuk Kim , Chao Yu CC: LKML , References: <1703a46c87dff3dbfdab008f1d268fe0b24c7db1.camel@perches.com> From: Chao Yu Message-ID: <86100529-fdb6-d06a-b002-454131415975@huawei.com> Date: Fri, 28 May 2021 10:08:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1703a46c87dff3dbfdab008f1d268fe0b24c7db1.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx703-chm.china.huawei.com (10.1.199.50) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/27 4:05, Joe Perches wrote: > Update the logging uses that have unnecessary newlines as the f2fs_printk > function and so its f2fs_ macro callers already adds one. > > This allows searching single line logging entries with an easier grep and > also avoids unnecessary blank lines in the logging. > > Miscellanea: > > o Coalesce formats > o Align to open parenthesis > > Signed-off-by: Joe Perches Reviewed-by: Chao Yu Thanks,