Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp124479pxj; Thu, 27 May 2021 23:22:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4BxEE5iGNMBtGsZrfWoAn0vi4zCXahFk9FYfGYwPTpE0dWVvfB/2VriXU3g/9VvwAsxEM X-Received: by 2002:a17:906:3712:: with SMTP id d18mr7592722ejc.155.1622182944847; Thu, 27 May 2021 23:22:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622182944; cv=none; d=google.com; s=arc-20160816; b=U4YNAEdI7damJPlLNap4Xr3Y4NrSVW2ZhqLCJi1OSl4AuhszGp9NiMqzBYzJvQ3t5E yCLr5XBwpJTCnIXeQwTWF4WX1j9fHmYr1E3fN0BkhahXFw8umapcowuknaDdAuqEtwdg wvH7RFqfFc0998PFTTbt+Egu/nfup0dAqq62sRm7cH7tQItOLO1GGAvbSW3WRRH62hdx oX00Zk95yH5WzYFZvfJx2lYcD/fpYdRbQKw8qETem1EBnmGXf8396BU3gUfoG0fmyuc6 /hz+qqVi7TOfB9xt1zU92rDlI78zHY5wQl1DQ7XyLf6BY+JtadJU8RQYxfwNi+U0+T3h baEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2T0XzvV0pPf+MKmPLbiuR872pRn1L7YO1Df+f+WOp8s=; b=yUT5L5AM8bXbHGAujzvQrJaeC5b0ha1NZCWk9AnlRpCNg2VPOfi2BDsY2lTlaxzN1U cKM589ypAI+qNOekx2XlXN75WiIZWNBEo8vCKxVTUMeyAlVhfUi2BE5Zn3zRDVMccnP9 48FQnQ/JF/GAvIAvhn0LI3sab+kmj46Pu7izRvsV40FkfyMdNqYHnpp1qDfRBM27swb4 xki3TWh84ko3T50eQhrSv2/YZTqrxBNv9mg8VtkV5XwA6EvUh8+3gAaydB8dI2Gm+uDD kdbWd5UCejo+KhFBi0cxwmJpti3WErSFTWURVGx+G0fRZOp50OC+1fzvYVaHwFn1Edpc vXkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="Tl66sh/s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rp11si4100438ejb.333.2021.05.27.23.22.02; Thu, 27 May 2021 23:22:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b="Tl66sh/s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234725AbhE1FXU (ORCPT + 99 others); Fri, 28 May 2021 01:23:20 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:62340 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233925AbhE1FXT (ORCPT ); Fri, 28 May 2021 01:23:19 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14S53P5d186076; Fri, 28 May 2021 01:21:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : reply-to : references : mime-version : content-type : in-reply-to; s=pp1; bh=2T0XzvV0pPf+MKmPLbiuR872pRn1L7YO1Df+f+WOp8s=; b=Tl66sh/syuwOYr/rf2XuZjv1zJXYlnIQC+Nr4hWXV+DpLSbrHasRyPSBvoRfDfGhbDK6 5h6Gj6Mpvzui1ggem5uVtPK/Fo6tzYYZJOo79KjaTiYhaIdb8eLeH7gJ9AN8LU/c7Oai gSMmKtQx35DY5Owb+dzgldHJSFMrqsVSPJ5cTOHCsJ8q4xnA4qBTCAyIQH4SB1HJb5fE DoGTz/N9npsQ8EnBe2qTdzxqA/ANxN5/ERs/syjanEbvwS9++/ts8wrikT9WMpc/XTHb f3oCP7gZya0Pj57/8NZEJmqa44D+ULubG0hyJGWG58NAd3ph+jp+D5UUFoYnfljp7gaw fg== Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 38tse9gyve-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 01:21:11 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 14S58pxl003148; Fri, 28 May 2021 05:21:09 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma04ams.nl.ibm.com with ESMTP id 38s1r49j41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 05:21:09 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14S5L6Dm33685844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 May 2021 05:21:06 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 483314C046; Fri, 28 May 2021 05:21:06 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADDC84C044; Fri, 28 May 2021 05:21:03 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.126.150.29]) by d06av22.portsmouth.uk.ibm.com (Postfix) with SMTP; Fri, 28 May 2021 05:21:03 +0000 (GMT) Date: Fri, 28 May 2021 10:51:03 +0530 From: Srikar Dronamraju To: Valentin Schneider Cc: Peter Zijlstra , Ingo Molnar , LKML , Mel Gorman , Rik van Riel , Thomas Gleixner , Vincent Guittot , Dietmar Eggemann , linuxppc-dev@lists.ozlabs.org, Nathan Lynch , Michael Ellerman , Scott Cheloha , Gautham R Shenoy , Geetika Moolchandani Subject: Re: [PATCH 1/3] sched/topology: Allow archs to populate distance map Message-ID: <20210528052103.GN2633526@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20210520154427.1041031-1-srikar@linux.vnet.ibm.com> <20210520154427.1041031-2-srikar@linux.vnet.ibm.com> <20210521023802.GE2633526@linux.vnet.ibm.com> <20210521092830.GF2633526@linux.vnet.ibm.com> <87k0no6wuu.mognet@arm.com> <20210524161829.GL2633526@linux.vnet.ibm.com> <87h7irglm9.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <87h7irglm9.mognet@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: u7QPXlkhZCRvKSlvx5XFp9HLC8oENy07 X-Proofpoint-ORIG-GUID: u7QPXlkhZCRvKSlvx5XFp9HLC8oENy07 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-28_02:2021-05-27,2021-05-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=520 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105280032 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Valentin Schneider [2021-05-25 11:21:02]: > On 24/05/21 21:48, Srikar Dronamraju wrote: > > * Valentin Schneider [2021-05-24 15:16:09]: > >> Ok so from your arch you can figure out the *size* of the set of unique > >> distances, but not the individual node_distance(a, b)... That's quite > >> unfortunate. > > > > Yes, thats true. > > > >> > >> I suppose one way to avoid the hook would be to write some "fake" distance > >> values into your distance_lookup_table[] for offline nodes using your > >> distance_ref_point_depth thing, i.e. ensure an iteration of > >> node_distance(a, b) covers all distance values [1]. You can then keep patch > >> 3 around, and that should roughly be it. > >> > > > > Yes, this would suffice but to me its not very clean. > > static int found[distance_ref_point_depth]; > > > > for_each_node(node){ > > int i, nd, distance = LOCAL_DISTANCE; > > goto out; > > > > nd = node_distance(node, first_online_node) > > for (i=0; i < distance_ref_point_depth; i++, distance *= 2) { > > if (node_online) { > > if (distance != nd) > > continue; > > found[i] ++; > > break; > > } > > if (found[i]) > > continue; > > distance_lookup_table[node][i] = distance_lookup_table[first_online_node][i]; > > found[i] ++; > > break; > > } > > } > > > > But do note: We are setting a precedent for node distance between two nodes > > to change. > > > > Indeed. AFAICT it's that or the unique-distance-values hook :/ Peter, Valentin, Michael, Can you please let me know which approach you would want me to follow. Or do let me know any other alternative solutions that you would want me to try. -- Thanks and Regards Srikar Dronamraju