Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp134468pxj; Thu, 27 May 2021 23:39:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7q/82nxnvHdknrwAJi7NSHHPZaJuvrz/v9whVecw21lwtW19WRCrZNpX9S9gnBy29wUIR X-Received: by 2002:a17:906:c1d0:: with SMTP id bw16mr7515544ejb.146.1622183993080; Thu, 27 May 2021 23:39:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622183993; cv=none; d=google.com; s=arc-20160816; b=dOYHm/gTIFZ7uMaQ+pco2DRkrjITprtvVqML7B0Ov/+Pale+AdDBK5AvjFQs/XBrjL RrD6wRteTaM1eTXcw1Lb08pATu/NSqsmDp2f/0/kcwev1aAX2xGoOOop6I3ewHunDLp1 Z0JQuTOXUF1QO0jkqMczSz9YGGL+Ptzt0BuuNgpe9m/aAcJN2rr/gj1MnutIUUpqNCUQ 9et9yXo3XciP58s91eHdVuOn8L1mipdVaIxaSGSMLRsuiWNh5QaE1xinf8pnmK1hCn9O SrAGRUqMHuwk2pmPgVQB1vKnbgNxNKFj214wac7v3GluVMVeMYf6KsRjht4dvMPiDHPH bzHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=tvDryGjFc2b0KujgcUtBe5I3gcYMEk3E/mVvu6Bxf/A=; b=jvKuRlrwxCST3JsX7vBWu2rtILFvpNk4w8vGBpy2zuHf8HQke17IJiDCMaq1r+NiuX decxpi75grzq8vfnZKQevVymJISVMxhV3awT4j7wKJCpMWqwMTdoGPTT/sxih5+fjxQ/ U28rwd9hhfritkGOpr03hzN6hhXClm16J9Gmji1UPUl6F/VHDB2j16QXICiuwnOBdCju t4mvvEIWZaSlqFf7kOpjV58Qq+XWY5ZpHtSlzG/lmrRgnjo7E90nrmkG1mb5KYg0UFFg X3ZXxfK2X0XF/YiDeiuD1QZNE8lrzxYOmXvK9CgawjhXPS9dS7S30yFyypRrDlFdiDrp sv1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=LjKnecBf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si3896936ejo.95.2021.05.27.23.39.29; Thu, 27 May 2021 23:39:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=LjKnecBf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhE1GbP (ORCPT + 99 others); Fri, 28 May 2021 02:31:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbhE1GbO (ORCPT ); Fri, 28 May 2021 02:31:14 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 270B2C061574; Thu, 27 May 2021 23:29:40 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 3577F22239; Fri, 28 May 2021 08:29:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1622183376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tvDryGjFc2b0KujgcUtBe5I3gcYMEk3E/mVvu6Bxf/A=; b=LjKnecBf9GWDYelaXriWtkwJLN0XzciFDPhk3Py6yqDSW73C1NwfxuMyy9lCqPtU8rzdvc CwAxmkDMpa/6TXJzBSxvbbOaHxLaufxpeSwWkbl53Ml1b3+IJEymd8ydw8x/j/8tjYm9PO 8YkC/Nr1g8H9TgFJZnNJGEvnDe5ntYE= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 28 May 2021 08:29:33 +0200 From: Michael Walle To: Sander Vanheule Cc: Pavel Machek , Rob Herring , Lee Jones , Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Linus Walleij , Bartosz Golaszewski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Andrew Lunn , Andy Shevchenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/6] pinctrl: Add RTL8231 pin control and GPIO support In-Reply-To: <185e8c61893502575c542750c8f27b09029e3078.1621809029.git.sander@svanheule.net> References: <185e8c61893502575c542750c8f27b09029e3078.1621809029.git.sander@svanheule.net> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <452144b056cb474321481c011ac9ccfb@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + gpio_cfg.reg_dat_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0); > + gpio_cfg.reg_set_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DATA0); > + gpio_cfg.reg_dir_in_base = GPIO_REGMAP_ADDR(RTL8231_REG_GPIO_DIR0); Btw. you'd only need GPIO_REGMAP_ADDR(x) if x might be 0. Because you have a constant != 0 there, you could save the GPIO_REGMAP_ADDR() call. You could drop this if you like, but no need to respin the series for this. -michael