Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 May 2021 09:26:36 +0200
From:   Lubomir Rintel <lkundrak@v3.sk>
To:     nizamhaider786@gmail.com
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] char: pcmcia: scr24x_cs: Fix failure handling of
 device_create()
Message-ID: <YLCbLND0Q+H2zL38@demiurge.local>
References: <20210527193429.696-1-nizamhaider786@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210527193429.696-1-nizamhaider786@gmail.com>
Precedence: bulk

Hi,

much better now, thank you.

Acked-by: Lubomir Rintel <lkundrak@v3.sk>

There's one small remark below.

On Fri, May 28, 2021 at 01:04:29AM +0530, nizamhaider786@gmail.com wrote:
> From: Nijam Haider <nizamhaider786@gmail.com>
> 
> Ignored error in device_create() and pcmcia_enable_device()
> this patch implements proper error handling.
> 
> Signed-off-by: Nijam Haider <nizamhaider786@gmail.com>
> ---
> V3 -> V4: Added label and moved the cleanup code
> V2 -> V3: Added description, Changelog and removed whitespace error
> V1 -> V2: Split the patch into two parts and addressed review comments
> ---
>  drivers/char/pcmcia/scr24x_cs.c | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
> index 47feb39af34c..ba84b4dd13d3 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -233,6 +233,7 @@ static int scr24x_probe(struct pcmcia_device *link)
>  {
>  	struct scr24x_dev *dev;
>  	int ret;
> +	struct device *dev_ret;
>  
>  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>  	if (!dev)
> @@ -271,22 +272,28 @@ static int scr24x_probe(struct pcmcia_device *link)
>  		goto err;
>  
>  	ret = pcmcia_enable_device(link);
> -	if (ret < 0) {
> -		pcmcia_disable_device(link);
> -		goto err;
> -	}
> +	if (ret < 0)
> +		goto err_device;
>  
> -	device_create(scr24x_class, NULL, MKDEV(MAJOR(scr24x_devt), dev->devno),
> +	dev_ret = device_create(scr24x_class, NULL, MKDEV(MAJOR(scr24x_devt), dev->devno),
>  		      NULL, "scr24x%d", dev->devno);
> +	if (IS_ERR(dev_ret)) {
> +		dev_err(&link->dev, "device_create failed for %d\n",
> +			dev->devno);
> +		goto err_device;
> +	}
>  
>  	dev_info(&link->dev, "SCR24x Chip Card Interface\n");
>  	return 0;
>  
> +err_device:
> +	pcmcia_disable_device(link);
> +	cdev_del(&dev->c_dev);
>  err:
>  	if (dev->devno < SCR24X_DEVS)
>  		clear_bit(dev->devno, scr24x_minors);
>  	kfree (dev);
> -	return ret;
> +	return -ENODEV;

Why -ENODEV? Couldn't we propagate the original error with something
like "ret = PTR_ERR(dev_ret);" just before the "goto err_device"?

Thank you,
Lubo

>  }
>  
>  static void scr24x_remove(struct pcmcia_device *link)
> -- 
> 2.17.1
>