Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp186597pxj; Fri, 28 May 2021 01:15:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9Qb8Zb77h5NMHAOlPD8GIDqcL13siYJrjxo5YElDvdcJWCoDFtQChjpUiZyIfvuJR6Epo X-Received: by 2002:a17:906:c448:: with SMTP id ck8mr7899998ejb.497.1622189744544; Fri, 28 May 2021 01:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622189744; cv=none; d=google.com; s=arc-20160816; b=XD0y+FEN4HdR8DQiZLPU94IPhDUk+fR1k+Tp2MK9WPqR9SiKGvlQFXgSaCVBVbIiGu 4+PGKET2HtI4p5z+Vdr2DB1CFvgPfBjEArAR99I88N2Q+2ZzhgoEqCiCoAUb9TX7sRPm 6tlPCUYeaW/+SSDLPV3o/UeCtJDdiv72GvvMkIu7ZA3iZyRAbq9gFzpatXYV6MBf25+u TqMGra+s2GzR9Sd5/c0NE1nt+BgRZHQ88KFFyF83KF5iKFFksumDftFhkc4R17ajk/ZI QmxSqAYMHxuZ5NLXIbVWzIQqfRYhbn9yHWKAqcpaAggHLWSAVJPEZQURX3PwsN9S0WJp iiTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=aybnPra2sVeCfC6CQFk9WQ6PiH+mkRdtC+qLokb0ZQc=; b=FxcrdnPcFqSXjlRpwtWcIoCLypSksFq7pfHtkuiqmVhYJqqsLrwcyUde/0ZZb8WelD MhBBCYMqLrHfIAFOPc03svqIDEK9KEX3V4ttPHrCQPijqz4/xBrIq7+JZNfS/svTPIQm rlBUNeJmbQIwW3m+NwYV6we6i041opORkAMhuerMyEOitAGPHh79cAsR/HhY2bEN7D7V mQmqJ3Jc3ex2MSjK4Icy45AAyvf4Ht1OBe5+NgwUI++FPvfllPXgVC/T+1yKqi7QfWIC K4L80Ww30vv6kLXpfKJA2plcZf/lO/jgwA3MukpgvGg/JJGLcW/ECfWwziymIKbSf0en CjAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id au2si4681553ejc.88.2021.05.28.01.15.20; Fri, 28 May 2021 01:15:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236093AbhE1IPK (ORCPT + 99 others); Fri, 28 May 2021 04:15:10 -0400 Received: from sauhun.de ([88.99.104.3]:39784 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236038AbhE1IPJ (ORCPT ); Fri, 28 May 2021 04:15:09 -0400 Received: from localhost (p5486cda0.dip0.t-ipconnect.de [84.134.205.160]) by pokefinder.org (Postfix) with ESMTPSA id 65EA72C0537; Fri, 28 May 2021 10:13:32 +0200 (CEST) Date: Fri, 28 May 2021 10:13:32 +0200 From: Wolfram Sang To: Qii Wang Cc: matthias.bgg@gmail.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, leilk.liu@mediatek.com Subject: Re: [PATCH] i2c: mediatek: Disable i2c start_en and clear intr_stat brfore reset Message-ID: Mail-Followup-To: Wolfram Sang , Qii Wang , matthias.bgg@gmail.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, leilk.liu@mediatek.com References: <1622117044-7583-1-git-send-email-qii.wang@mediatek.com> <1622165863.15667.3.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OJPvFYrtr07vTo0J" Content-Disposition: inline In-Reply-To: <1622165863.15667.3.camel@mhfsdcap03> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OJPvFYrtr07vTo0J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 28, 2021 at 09:37:43AM +0800, Qii Wang wrote: > On Thu, 2021-05-27 at 22:14 +0200, Wolfram Sang wrote: > > On Thu, May 27, 2021 at 08:04:04PM +0800, qii.wang@mediatek.com wrote: > > > From: Qii Wang > > >=20 > > > The i2c controller driver do dma reset after transfer timeout, > > > but sometimes dma reset will trigger an unexpected DMA_ERR irq. > > > It will cause the i2c controller to continuously send interrupts > > > to the system and cause soft lock-up. So we need to disable i2c > > > start_en and clear intr_stat to stop i2c controller before dma > > > reset when transfer timeout. > > >=20 > > > Signed-off-by: Qii Wang > >=20 > > Is there a suitable Fixes tag for this? > >=20 >=20 > Can you help to add the following tag, thanks > Fixes: aafced673c06("i2c: mediatek: move dma reset before i2c reset") Added this tag and applied to for-current, thanks! --OJPvFYrtr07vTo0J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmCwpisACgkQFA3kzBSg Kbb03RAApmrkJIj//VaDqHQN7GyWM+5ruaKD22kJSm4fL8ozUu28fCSIk3ni1aK0 Pn2mXRSzGWzBWXFIaHEPISfaQSYYaeoGD5sgJJMcf/y6weyLlgn4SeIASsY+ijkY rIfV1uqyzBUdUjAKXD9MfS/2VpNB5aj/5NXvqBv/wiKbjFRGZfIQ8JDv3oHViSmM Fom+2RtQSbrZlO6eRafzIcfRUzDsFNL3umd4bG+35FQ+WVvRUzOKlKVRRECmj8aE lpTNsaFTYfkr9L287bZxnOVb2bikxw6PnFQ842U3g9UZnM1IlVCUZws7V1tOVnFm LpPvzevBtJ+sD248PRhpq6HT1ZtZC6fD6Ngi36aScsk1KbaGktomG+Av7VvN4fgA /k2KiDJ2hH5g1XfeVvtxr6exyiDKVJDuDv4jgDobsDNlZdP1G+gum1mp4R5CjC5V N8mr0dvc1YzZWHsSS/JAI6coKMqnO4E16NuVLHuTc10a+sfE4aXsYoKppsSZQHBA ptvEQSc/WWCKG9lskmCuwdFd8DSywnk+1HPCZw4WfppDX40USMSSmKsZUCjG5Tz/ PFz6vy4qYZB0aYDAkuA2fhkZZD4VgwWBy08xbubSSGmePWGwvRsHdYRq0OyClA/R 6HfLbcT5Ch3IflK03jUJYNEyisJsIPVp4qB1BocG6jmoeXha9Qc= =sw0e -----END PGP SIGNATURE----- --OJPvFYrtr07vTo0J--