Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Borislav Petkov <bp@suse.de>, James Feeney <james@nurealm.net>,
        linux-smp@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        lkml <linux-kernel@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        x86-ml <x86@kernel.org>
Subject: Re: [PATCH] x86/thermal: Fix LVT thermal setup for SMI delivery mode
In-Reply-To: <YK/q4RyKhoqFM2nJ@zn.tnic>
References: <YKYqABhSTTUG8cgV@zn.tnic> <a264eaef-1c94-77e1-dfbf-e436a41588be@nurealm.net> <YKjJfu4kRDflQS5e@zn.tnic> <373464e3-b8a0-0fe0-b890-41df0eecf090@nurealm.net> <YKqLSqIM7Gi5x+IA@zn.tnic> <b550a241-2097-cf4b-cc41-e4d0a45cda72@nurealm.net> <YKtbBXZGpVZS1M4R@zn.tnic> <1f6c70f4-6680-d6ea-465a-548dc7698317@nurealm.net> <YK905sC/2cVOYo6I@zn.tnic> <87h7io8kh5.ffs@nanos.tec.linutronix.de> <YK/q4RyKhoqFM2nJ@zn.tnic>
Date:   Fri, 28 May 2021 10:23:42 +0200
Message-ID: <87mtsf6zch.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, May 27 2021 at 20:54, Borislav Petkov wrote:
> On Thu, May 27, 2021 at 01:49:42PM +0200, Thomas Gleixner wrote:
>> Also if disabling this entry is causing the BIOS/SMM gunk to go south, then
>> disabling CONFIG_X86_THERMAL_VECTOR should have the same effect.
>
> Well, I believe the latter was practically impossible:
>
> config X86_THERMAL_VECTOR
> 	def_bool y
> 	depends on X86 && CPU_SUP_INTEL && X86_LOCAL_APIC

So you could disable CPU_SUP_INTEL ... Should still boot with reduced
functionality.

> so *if* the machine was sporting thermal SMI, then it very much needed
> that code in intel_init_thermal() to unstuck the cores. At least it
> looks that way...

What a mess...