Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946535AbWKAFuD (ORCPT ); Wed, 1 Nov 2006 00:50:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946542AbWKAFnt (ORCPT ); Wed, 1 Nov 2006 00:43:49 -0500 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:15836 "EHLO sous-sol.org") by vger.kernel.org with ESMTP id S1946538AbWKAFne (ORCPT ); Wed, 1 Nov 2006 00:43:34 -0500 Message-Id: <20061101054231.472027000@sous-sol.org> References: <20061101053340.305569000@sous-sol.org> User-Agent: quilt/0.45-1 Date: Tue, 31 Oct 2006 21:34:20 -0800 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Herbert Xu , David S Miller , Greg Kroah-Hartman Subject: [PATCH 40/61] SCTP: Always linearise packet on input Content-Disposition: inline; filename=sctp-always-linearise-packet-on-input.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 47 -stable review patch. If anyone has any objections, please let us know. ------------------ From: Herbert Xu I was looking at a RHEL5 bug report involving Xen and SCTP (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212550). It turns out that SCTP wasn't written to handle skb fragments at all. The absence of any calls to skb_may_pull is testament to that. It just so happens that Xen creates fragmented packets more often than other scenarios (header & data split when going from domU to dom0). That's what caused this bug to show up. Until someone has the time sits down and audits the entire net/sctp directory, here is a conservative and safe solution that simply linearises all packets on input. Signed-off-by: Herbert Xu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman Signed-off-by: Chris Wright --- net/sctp/input.c | 3 +++ 1 file changed, 3 insertions(+) --- linux-2.6.18.1.orig/net/sctp/input.c +++ linux-2.6.18.1/net/sctp/input.c @@ -135,6 +135,9 @@ int sctp_rcv(struct sk_buff *skb) SCTP_INC_STATS_BH(SCTP_MIB_INSCTPPACKS); + if (skb_linearize(skb)) + goto discard_it; + sh = (struct sctphdr *) skb->h.raw; /* Pull up the IP and SCTP headers. */ -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/