Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 May 2021 10:27:41 +0000
From:   Rudi Heitbaum <rudi@heitbaum.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Ezequiel Garcia <ezequiel@collabora.com>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        chenjh@rock-chips.com
Subject: Re: [PATCH] regulator: fan53555: add back tcs4526
Message-ID: <20210528102737.GA418788@96e513df87d1>
References: <20210526162342.GA20@8bbba9ba63a4>
 <CAMdYzYpZoKs3P62j02RW-+5BEpqC9JL3apjucTWLWmvNFrOrCg@mail.gmail.com>
 <20210527105943.GA441@7698f5da3a10>
 <462b8d80447efb6c00e93704914169bceb5adc4d.camel@collabora.com>
 <YK+ZMdD+7uqQwCow@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YK+ZMdD+7uqQwCow@sirena.org.uk>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Mark,

I have submiited the v2 patch. Thanks for the feedback too.

On Thu, May 27, 2021 at 02:05:53PM +0100, Mark Brown wrote:
> On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> > On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:

> > > +       /delete-property/ operating-points-v2;

> > Removal of the operating points kind of makes the gpu regulator moot,
> > don't you think?

> It's still better to say what the supply is even if it can't be
> changed - that stops you getting warnings about substituting in a
> dummy regulator and allows the consumer to read the current state
> of the regulator in case that's useful.

I'll look into this.
Thank you all for the feedback and direction on the dts.

> > > +???????????????regulator-compatible = "fan53555-reg";
> 
> > I can be wrong, but I think regulator-compatible is deprecated.
> 
> Yes.

will action

> > > +???????????????regulator-boot-on;
> 
> > Just out of curiosity, is regulator-boot-on really needed for the GPU?
> 
> It should only be used if it's not possible to read the state of
> the regulator enable from the hardware.

will do further testing