Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp274338pxj; Fri, 28 May 2021 03:47:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweH4wHyNmBEoMmPmVh1xwKXWbS/WOggpH1/yhUxyAZFVQ31DZkMcDko4dmktkq0PnuRb+A X-Received: by 2002:a17:906:fcb5:: with SMTP id qw21mr251800ejb.57.1622198870807; Fri, 28 May 2021 03:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622198870; cv=none; d=google.com; s=arc-20160816; b=Ntv5/AChJIATeQThAhlkKaub/JKfckL2YfNWOb/1dER0jFHEadvBlocwrMqBwuauZy tWZKCsia1gpPG7RTnTioUHzQq6Y1JwR2Q6tDivX9j946McoOTl53fRD/WnNNvGm2n4Jp nH423mWqY+MlS+9sH/LiI2o1ULV74fE4VZVNSP1I+G1lWwopNiaISr5H63lPzzU13T2j SZlOyuadT+SlQ0nlw7rMuazjwCwnSO99i/DDiTLVi+L51oxCn8MVXPGLJhyaUFOuc8l+ 73N9Xhr1Lc0WUoOB6nPidl37GKWLRKel8qQoDOWPOSZ9U7rSzCuWlH94TB4UbE/zb1QA zMJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=3IZ7SlJQzr9yIERaHXvzJGOTdIAb6VIe+0OeYsY3JvY=; b=HAvLBxt5f17VK7WQyXVowKZNsNHzcTtmodS3oTo4+AlXuWNFL7KjdUEKGn0WCBky0w PVIbqFV2bN+elr/416kebY0kVWtBolsmC1l4uRG8QB3BM7f8EZRgcDmRcxJ0m7SexF89 tm+XTCyMSXaPWNe70z+CRCbydqzkV1qJE/HbaRr2a4W5Wntl4IviGE31JkJa09RNYuim iu4mQ6EHK1C2caHd3hGg5xS525MYaJroElQt24gaqaa2wODECu6m2+f6C+TSmxRQPuHs +scbSPIXoI+Vmp40eBSucyDXxSTn438pXgzbKfhf2QcgqeFQ4HcrqyWkzmnzbihMWb2n lzzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si4328543edw.281.2021.05.28.03.47.27; Fri, 28 May 2021 03:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236541AbhE1KrP (ORCPT + 99 others); Fri, 28 May 2021 06:47:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:53668 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236340AbhE1KrN (ORCPT ); Fri, 28 May 2021 06:47:13 -0400 IronPort-SDR: YsePYQJD8tTo0UOVaqrZINZuuC98X7vZS8IWuIzoIVLrzteSE3um5PPRJcf8olZwbkWQ0ED/b+ /dvtD+TPqJuw== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="224166045" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="224166045" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 03:45:38 -0700 IronPort-SDR: bbuC1joOym2GH0be1kABCGUGS8fy59so6ikZaWMxUoC1GT44vRQcUTA1V8pg5ys7z54svUUn6x AStv45sMm1lw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="465837093" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 03:45:34 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lmZzf-00FIDS-NS; Fri, 28 May 2021 13:45:31 +0300 Date: Fri, 28 May 2021 13:45:31 +0300 From: Andy Shevchenko To: Pavel Machek Cc: Amireddy Mallikarjuna reddy , Linus Walleij , Marek =?iso-8859-1?Q?Beh=FAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 03/28] leds: el15203000: Give better margin for usleep_range() Message-ID: References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> <20210510095045.3299382-4-andy.shevchenko@gmail.com> <20210528100440.GE2209@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528100440.GE2209@amd> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 12:04:40PM +0200, Pavel Machek wrote: > On Mon 2021-05-10 12:50:20, Andy Shevchenko wrote: > > 1 microsecond with 20 millisecond parameter is too low margin for > > usleep_range(). Give 100 to make scheduler happier. > > > > While at it, fix indentation in cases where EL_FW_DELAY_USEC is in use. > > In the loop, move it to the end to avoid a conditional. > > Its not like unhappy schedulers are problem... Any hints then? To me it sounds like torturing scheduler is the real problem and that's why scheduler is unhappy. -- With Best Regards, Andy Shevchenko