Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qn1e/5GeU4f+tZWShtvDz9xoV81ErfqgU5pUo8R6RTUXVSIybBgpPyctOA83m1wcDuSiEF8nR7
 3htd9PLpVuAQ==
IronPort-SDR: uAJZQ4kGZxT8yM1Hc8dvDcBEnkdMBK0oGayVCzkIKa/uPeMzdM8kWqbBomJsEkmae/8Ayb7dKE
 qToo+ruMlyFw==
Date:   Fri, 28 May 2021 13:49:01 +0300
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marek =?iso-8859-1?Q?Beh=FAn?= <marek.behun@nic.cz>,
        Abanoub Sameh <abanoubsameh8@gmail.com>,
        Dan Murphy <dmurphy@ti.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource
 cleanups
Message-ID: <YLDKneVl0DefNdAW@smile.fi.intel.com>
References: <20210510095045.3299382-1-andy.shevchenko@gmail.com>
 <20210510095045.3299382-12-andy.shevchenko@gmail.com>
 <20210528100906.GG2209@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210528100906.GG2209@amd>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, May 28, 2021 at 12:09:06PM +0200, Pavel Machek wrote:
> On Mon 2021-05-10 12:50:28, Andy Shevchenko wrote:
> > The idea of managed resources that they will be cleaned up automatically
> > and in the proper order. Remove explicit cleanups.
> 
> Are you really sure this is good idea with the regmap_update_bits in
> between?

Good question. I will check it.

> > -	/* unregister led */
> > -	devm_led_classdev_unregister(priv->dev, &led->cdev);
> > -
> >  	/* clear HW control bit */
> >  	if (led->desc.hw_trig)
> >  		regmap_update_bits(priv->mmap, SSO_CON3, BIT(led->desc.pin), 0);
> >  
> > -	if (led->gpiod)
> > -		devm_gpiod_put(priv->dev, led->gpiod);
> > -
> >  	led->priv = NULL;


-- 
With Best Regards,
Andy Shevchenko