Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <60B0B31A.7070301@gmail.com>
Date:   Fri, 28 May 2021 12:08:42 +0300
From:   Eli Billauer <eli.billauer@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] char: xillybus: Add driver for XillyUSB (Xillybus
 variant for USB)
References: <20210526100311.56327-1-eli.billauer@gmail.com> <20210526100311.56327-3-eli.billauer@gmail.com> <YK+Mlw0Tn7eGFPI2@kroah.com>
In-Reply-To: <YK+Mlw0Tn7eGFPI2@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/05/21 15:12, Greg KH wrote:
>> diff --git a/drivers/char/xillybus/Makefile b/drivers/char/xillybus/Makefile
>> >  index 591615264591..16f31d03209d 100644
>> >  --- a/drivers/char/xillybus/Makefile
>> >  +++ b/drivers/char/xillybus/Makefile
>> >  @@ -7,3 +7,4 @@ obj-$(CONFIG_XILLYBUS_CLASS)	+= xillybus_class.o
>> >    obj-$(CONFIG_XILLYBUS)		+= xillybus_core.o
>> >    obj-$(CONFIG_XILLYBUS_PCIE)	+= xillybus_pcie.o
>> >    obj-$(CONFIG_XILLYBUS_OF)	+= xillybus_of.o
>> >  +obj-$(CONFIG_XILLYUSB)		+= xillyusb.o
>>      
> This doesn't quite work.
>
> Even if I have not selected CONFIG_XILLYBUS I get asked aboug
> CONFIG_XILLYUSB.
The symbol tree is:

XILLYBUS_CLASS --+-- XILLYBUS --+-- XILLYBUS_PCIE
                  |              |
                  |              +-- XILLYBUS_OF
                  |
                  +-- XILLYUSB


Hence not selecting CONFIG_XILLYBUS doesn't eliminate CONFIG_XILLYUSB. 
The behavior you described is correct: CONFIG_XILLYUSB doesn't depend on 
CONFIG_XILLYBUS.

>   And if I say 'm' to CONFIG_XILLYUSB, nothing gets
> built.
>
>    
Sorry, my bad. The directory is currently invoked based upon 
CONFIG_XILLYBUS, which was correct before, but now it should be 
CONFIG_XILLYBUS_CLASS. I'll submit a patch fixing that promptly.

Plus another patch removing MODULE_VERSION() from all C files, per your 
earlier comment.

Thanks and regards,
    Eli