Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp356005pxj; Fri, 28 May 2021 05:45:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP0Mmlv7fhltx4f12enA5VEdnHDGfY0Yftoowk4I4LcP60CtG5Ek2XYn9MApBmNJ0N+fHn X-Received: by 2002:a17:907:781a:: with SMTP id la26mr8838877ejc.435.1622205935168; Fri, 28 May 2021 05:45:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622205935; cv=none; d=google.com; s=arc-20160816; b=GxfQq4gH2FDuUlWsRcnWnJHG8J5yait/VJ4TuxNQaZri4nNhviugjug4Td+rhV9pzC GHcDAWy/486s5bMlZi+mI3LFBO3VGiu+KPuvQ6NDhmBzZkjSj6us8pJEd6nZT/g6kh61 t0uiBxsNBbQyO61DcrfG6Vp7/1Xclm/50zdbMVxB0GePvfdVhN93o5qZ10FsFgFKY9Tn ot7yP+1hngcWNM/I04TdP8KaBpRKMG++XfgHeO16EXOIVOVYT3tWZfzmyYy4wbMrJrRq CkGSuyEMsMpM8sTeHBR806rs8g1gnYLgk8NsrP5zPBAQRczIzArjADsZos7XC7aLM76E vxDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=G3Q2tksrkhJxdvwhNQPoZFzNaFf4kubWs5c1nK9+kN8=; b=MIDOIaOW8dxdIiZhc3xL6n5v3UCd6QEcyUK+nWpTI1wQGaaA80FNnpWRWp1sgMfZlV N/2lyEhNEZHaPlklVq/auQn+38/rljJoB16M1G3hcIpXJQ4J4/0N0sGTtG0sBFC6c0ZL um+CAvJRiArAkoYN9GxRrHlWymKRqDSC1rpxOoJPxBZS4pF+vaR9YezNCRFrcFsMAnam l1DUX1xYmw26lpfgDmB+1oz0UsoQYrNJQgEZ29RXlKJXdnkgHobi6S+sD7GKEcSB7lvZ Yi1ElYUyNqmh1UhEiXfr48YxXmoORTrJVvDEYZezO1Tau713qPbSZO8Wtyey4MSVe6/T SEXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="go3a0/Ql"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x10si4704649eji.476.2021.05.28.05.45.09; Fri, 28 May 2021 05:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="go3a0/Ql"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233845AbhE1MZM (ORCPT + 99 others); Fri, 28 May 2021 08:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232852AbhE1MZM (ORCPT ); Fri, 28 May 2021 08:25:12 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5930DC061574 for ; Fri, 28 May 2021 05:23:37 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i9so4987585lfe.13 for ; Fri, 28 May 2021 05:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G3Q2tksrkhJxdvwhNQPoZFzNaFf4kubWs5c1nK9+kN8=; b=go3a0/QldXwLUCsSTRpbFZ8KKeW0RPYh5QJ3Wnsw2S8BJIvnzKSMDOABlCZXC032Yn Y6cjXU/fvNXI/J6bLEYNA2lUU9/Vcv63xjhqBhkKQhn8v8dO8gythQqEtfQ1wsedwsZn SrUsXCgC44fWU7SNCmDWBwNdv/yMiNyGtcYRM9ATua43XblVjvKYQLqH81wNe51rVgJL JOKKPj4XAHE2Rxd6vLKAY+2A+FYRpK+XWs+RoJoKrJeM8TrABZY3z5t2iJsZVr87yjjn 3ctC552sZTl4wFvMXcK+93OWsBfzpCs9bM3e/Gw0KDZD468Jo/FjdscYpw+klYplKoCz wV1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G3Q2tksrkhJxdvwhNQPoZFzNaFf4kubWs5c1nK9+kN8=; b=kGIFWmJw6jMVtZiZWux8PsIx6kve7GYXq794iSr/itZoow31c67DYT0mv65JAesT5A Ylz7mPHOi5qai9U02XVbRocN9sy66br8bhFxPoZcEiRIZ41ib98WJLAZ06AQ4Qwb6ap8 2SFtcHBCtGxuCxgsHuWi9dbMfUjTg9nwdSntmNb3NdjxOSwcpZ1hYucMgNscfHi6rQkD 1T9jm7I3v5WxJr7HYFzyvvnL2gyFt4P3QX27J3H68xR+BM5O4MdCMBkhgJVrwSZGz5Z7 6f06z2y1FUlOK9I8T4Le4I/jSoqH7ueNA5s+MxGEuO1DaE4KjqHWjd8iW7hX+Sv70FE9 3M3w== X-Gm-Message-State: AOAM533ygtkvwtuCe5pmu9AoA/kdPFPpHfMyHCwJOBes+bMn2WrGuzDE mLeAMaoqgKGb2tPSGcWXLB+il+IngUOffTNwiH4sbQ== X-Received: by 2002:ac2:544f:: with SMTP id d15mr5674797lfn.465.1622204614193; Fri, 28 May 2021 05:23:34 -0700 (PDT) MIME-Version: 1.0 References: <20210518120633.GW12395@shell.armlinux.org.uk> In-Reply-To: From: Linus Walleij Date: Fri, 28 May 2021 14:23:23 +0200 Message-ID: Subject: Re: [PATCH v2 5/6] ARM: use "* SZ_1M" rather than "<< 20" To: "Russell King (Oracle)" Cc: Yanfei Xu , Mike Rapoport , Ard Biesheuvel , Andrew Morton , Hailong liu , Tian Tao , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 12:11 PM Russell King (Oracle) wrote: > Make the default vmalloc size clearer by using a more natural > multiplication by SZ_1M rather than a shift left by 20 bits. > > Signed-off-by: Russell King (Oracle) Excellent, thanks! Reviewed-by: Linus Walleij Yours, Linus Walleij