Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     torvic9@mailbox.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc:     "linux-mm@kvack.org" <linux-mm@kvack.org>
References: <1825464932.40588.1622203733380@office.mailbox.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Subject: Re: [Question] mm/vmpressure.c: ilog2 calculation in constant
Message-ID: <7a34c010-9f2a-431b-3c49-8f0d387f1cba@redhat.com>
Date:   Fri, 28 May 2021 15:08:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <1825464932.40588.1622203733380@office.mailbox.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 28.05.21 14:08, torvic9@mailbox.org wrote:
> Hello,
> 
> in mm/vmpressure.c, we have defined this constant:
> 
>    static const unsigned int vmpressure_level_critical_prio = ilog2(100 / 10);
> 
> My question is: Why do we calculate ilog2 instead of simply setting the constant to '3'?

My best guess is that it's in place to a) increase readability b) make 
it easier to adjust. The compiler will optimize it out either way, so we 
don't really care.

Having that said: it doesn't increase readability on my end. But I only 
took a quick glimpse. Maybe the "100 / 10 == 10" here is the magic bit 
also mentioned in the comment "when scanning depth is ~10%". So it can 
be adjusted "more easily" eventually ... at least not by me.

-- 
Thanks,

David / dhildenb