Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 4/6] ARM: change vmalloc_start to vmalloc_size
To:     "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc:     rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org,
        akpm@linux-foundation.org, carver4lio@163.com,
        tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20210518120633.GW12395@shell.armlinux.org.uk>
 <E1lmZT1-0005Te-4i@rmk-PC.armlinux.org.uk>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <56b01e19-6509-e6a1-30d1-ac71ec8724b4@windriver.com>
Date:   Fri, 28 May 2021 21:15:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <E1lmZT1-0005Te-4i@rmk-PC.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [128.224.162.160] (60.247.85.82) by HK2PR04CA0078.apcprd04.prod.outlook.com (2603:1096:202:15::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Fri, 28 May 2021 13:15:50 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48f594b4-d1d0-4952-6759-08d921dab87d
X-MS-TrafficTypeDiagnostic: SJ0PR11MB4862:
X-Microsoft-Antispam-PRVS: <SJ0PR11MB486269225F8D4213FF699F9FE4229@SJ0PR11MB4862.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rpEOf6460IJWpnCsT49QOWX4ky0gBlG/JazM8PQu7y6zhZsefvba65/p8HVU1yhHdiFkufabPoH69xQdpNS1RpUV36qkW3EdVBwzQSayYojnKy8kyNdILw+17nzreqFylff479Jkm4PbrZ7y07KjbRG1POfH6oFAvnS2DCn0YECg114MxshVnUAAbFAhtuzuz7W3/Th1NREa1r3SB1+WWJFu3wPlV7gmDNx5eKTlStANagwRqjwokLJfU5IsE3fAuL/6k8iL/w/MZPjPmDflKkniKBx8gCi15TLFegnX7to8Vrj4+7kV1R/NQOMDCD69TZwyA9CGBzmu7oyx7n8EY08nnM286TJsiPoM5VWEdfHnFvkdI+QFJlGaMwwrVY2NfOkpcyEzmZSXOLKzTg3gb6Om1pcS0Wrr3bKxEOxXiVRjYKdC/LZCR4BvNspPp43s41kkyL5eSuwzS8EAAd76sRu1ztc1EZgG9DxwjHI7nFjATRRx8rDVsl/N7Iqd/crB+uqKG1Kt1ZFYBUsUiwRa6qfux859tIGvjDDdAfLXLXZ0nBAITCFmLwUNX174OdJyMYjWCN0tskeKp3Vfuk8Hf9gbPavPDOVaDiFcGX9QosBacWxELPBmpbgMXQXktTqhB5XKD/IS/EJWUUbufmENNcXyTng7/TcNxIeK3qcskjKMZGsjysdwpE1m3eo8Or18yWsxY51GWEhXkmv/iWDM7pD0FEbnYgtgbtNqjmTSzqg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4241.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39840400004)(376002)(136003)(396003)(366004)(52116002)(53546011)(83380400001)(36756003)(26005)(38100700002)(38350700002)(86362001)(2906002)(6706004)(31696002)(8936002)(2616005)(956004)(16526019)(186003)(4326008)(6666004)(66556008)(66946007)(6486002)(8676002)(31686004)(316002)(5660300002)(66476007)(478600001)(16576012)(78286007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aWVZQURVQmhxcTdxNkwva1IrMHJ5bmNYeVJ1OTNYNFUzdnZmd3lnOHJHS205?=
 =?utf-8?B?Qm1CbUlaTVJCNkg5MUUrMU1ZeVRhczFOQmVlaU9LL1l5bUVyc3BwUi93U2R1?=
 =?utf-8?B?STRQOStpSzBSeFp6SWJ5SnV2Y2FqaWJvbExzaUtWaWxBcUFobllZN3FiQWlS?=
 =?utf-8?B?Y2U1U2twNzVkN0w2ek1GRzliVlBJZEE2VFpwcXNVNzNOLzU5VTZQa0tkeGRa?=
 =?utf-8?B?NXo1S3QvbEFWUGU3eVQveTFlbTM3Q2lRbjYxaTF3YlVmWjhpVXpYVC91ZG9o?=
 =?utf-8?B?WFdUUytyZkRqdjdTMk92aytVMEY1d3pWZndQQWd6WjFrTjg3T1l4UG5IR2VW?=
 =?utf-8?B?UmN1OE1mTmRhZksrODF3cy9rQUE4K0QxM2FrSFlzMDk5L1lHTW4yWXJuUXhK?=
 =?utf-8?B?NVNSVHZpK3pXSmNGM3VOcjQ1cHFjdGxyNUVrU2xrVXRTS2IwckY1YWhuc01y?=
 =?utf-8?B?aHRDS1h2d25oZ0ZnY012SDd0ck8zNmlFSXZrNXlHTEVLV1daNkJYcFdaM3lD?=
 =?utf-8?B?OGNiYzExUHdGWXBjSXV2WDZDWGtHcHhldytoMFZoVjM5WHRRaXpSY1VWRTE3?=
 =?utf-8?B?QmE0U1UxdHRwOXNpYUdTeHg4REZxSHcyajlFaXZWdFhCSG5aWUwrSml5Wjhn?=
 =?utf-8?B?eHJ2OE51bERSdytUaVNrRnJDT0tDM3NWcTI3ckFGdk42cDNaSmhwYVgwbERC?=
 =?utf-8?B?SzBlbUxuaEh4b3NQbWgxL3hJR0xoK1RCVVhacmFmbWdrcld2T2UzTzVVMEFB?=
 =?utf-8?B?N0hCVFVZa1VOUkU1dFVCL2tVSTN4UlJkS3hETmVUZXNYMlh1WVc0RjhRVm9T?=
 =?utf-8?B?d0R3LzNoZkcxYzVVeDg5M1lHOTZJS1Zram13UWtsZTExL2x6Q3c3cGhLZjBH?=
 =?utf-8?B?R0RXQjhpZ25rMzdnUXREK1h3RzRqLzJuZUMxWmlwakRoay9FL3AwS3FjRkNs?=
 =?utf-8?B?TkcrSVVWb1ZmV2x1RzFkUVJDbHM0K2ZFQWE0ZkVOZnd3VVllanRTZ2greXF6?=
 =?utf-8?B?WEtpb2MyWklDYTlhUkptSEs1b3M4N2NWYUtPWFFVaXovV0NhWmdKd0h0eEhP?=
 =?utf-8?B?dG1ENk4rWm1NMk5mcHpramN2V0xMNWdXSE4xc3p2d3VXUDRPS1hZWVhES0Iz?=
 =?utf-8?B?NnFkQklHMFBsQ3pDbG92NzArNzIwc1pvRGhIRTdsMXR1VnN6bWVYdmVBNWFm?=
 =?utf-8?B?UnNiVHI4eVVpR0JnS1Z2Wjl6QTdoYUw0L0VvbEpQSHk5cWM3Y3dHSnh0ZUZz?=
 =?utf-8?B?U0hXYWJPeW1KbWx5NzNVMGhFaWZtVkM2bU1MR3VqbkwvK1VYRGU2OWxVaWda?=
 =?utf-8?B?OFhOeDJ6a0FNRTJoVGczYWhwVEpRb2h2Wm9vYkdIc3k3Qy9hcjFMdmlKUlFQ?=
 =?utf-8?B?VTQxZVUrRitRQTV6ckZOaHFyWkZPcHF2NnpBelJPK1h4VS9vOGhhT2hmK29F?=
 =?utf-8?B?V3M3UWtQczdBTjJqdG9paVFqUTlMWG5KeU54OGlxaXg1SnBCeXFaVDJlRFBX?=
 =?utf-8?B?N3VGMVdHMjV3OWJtSWJDWHhubnhLNmRsaTVGYlI1OXpZKzEzZDloVW1uN3B0?=
 =?utf-8?B?cVhZT1pqUm9LaERBV0NBWHZOVDN3QmRqVk4vaWFsTzFKaFp5K2hBYm5PRWFH?=
 =?utf-8?B?aHllMlFVc1BMWkJZNzJuVWpHTDVqeFBobHE4TjJLS2Z4bEpQL0pTM2FhT1R4?=
 =?utf-8?B?YkQ2YjVQcVNBMEFBeVh1UFA1NDJ6UVIyZytaV2dPSEt6ankrMlE3WEZGVWlw?=
 =?utf-8?Q?QmS6HF9nfPm+vvHxyrlgJcegw+ETYWFAQz/Rx7Y?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48f594b4-d1d0-4952-6759-08d921dab87d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4241.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2021 13:15:53.2958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RGO3Nj6J4Zojuab/mVer6nmVJcX1LQIkrEtjtJKoVUhy0EBeEL7Qgpri3dgmuBZmJGrkyJvR0SyD2lO+clC38g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4862
X-Proofpoint-ORIG-GUID: Jhd97s9bMeA7UE3DI3F1tB2WUgcdIBqF
X-Proofpoint-GUID: Jhd97s9bMeA7UE3DI3F1tB2WUgcdIBqF
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-28_04:2021-05-27,2021-05-28 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 clxscore=1015 phishscore=0
 impostorscore=0 mlxscore=0 priorityscore=1501 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105280089
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/28/21 6:11 PM, Russell King (Oracle) wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> Rather than storing the start of vmalloc space, store the size, and
> move the calculation into adjust_lowmem_limit(). We now have one single
> place where this calculation takes place.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Reviewed-by: Yanfei Xu <yanfei.xu@windriver.com>

Regards,
Yanfei
> ---
>   arch/arm/mm/mmu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index ed2846bdb1f4..5ae11e6f2a58 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1123,7 +1123,7 @@ void __init debug_ll_io_init(void)
>   }
>   #endif
> 
> -static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
> +static unsigned long __initdata vmalloc_size = 240 << 20;
> 
>   /*
>    * vmalloc=size forces the vmalloc area to be exactly 'size'
> @@ -1148,7 +1148,7 @@ static int __init early_vmalloc(char *arg)
>                          vmalloc_reserve >> 20);
>          }
> 
> -       vmalloc_start = VMALLOC_END - vmalloc_reserve;
> +       vmalloc_size = vmalloc_reserve;
>          return 0;
>   }
>   early_param("vmalloc", early_vmalloc);
> @@ -1168,7 +1168,7 @@ void __init adjust_lowmem_bounds(void)
>           * and may itself be outside the valid range for which phys_addr_t
>           * and therefore __pa() is defined.
>           */
> -       vmalloc_limit = (u64)vmalloc_start - VMALLOC_OFFSET -
> +       vmalloc_limit = (u64)VMALLOC_END - vmalloc_size - VMALLOC_OFFSET -
>                          PAGE_OFFSET + PHYS_OFFSET;
> 
>          /*
> --
> 2.20.1
>