Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210528034615.2157002-1-masahiroy@kernel.org>
In-Reply-To: <20210528034615.2157002-1-masahiroy@kernel.org>
From:   =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <f4bug@amsat.org>
Date:   Fri, 28 May 2021 15:47:19 +0200
Message-ID: <CAAdtpL77zwffQAP6ihf5kQ6E5nOmOOnHZ8KD33ZN+kNGU0sZLQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] mips: syscalls: define syscall offsets directly in <asm/unistd.h>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Alexander Lobakin <alobakin@pm.me>,
        Geert Uytterhoeven <geert@linux-m68k.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, May 28, 2021 at 8:11 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> There is no good reason to generate the syscall offset macros by
> scripting since they are not derived from the syscall tables.
>
> Define __NR_*_Linux macros directly in arch/mips/include/asm/unistd.h,
> and clean up the Makefile and the shell script.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>  arch/mips/include/asm/unistd.h         | 4 ++++
>  arch/mips/kernel/syscalls/Makefile     | 6 +-----
>  arch/mips/kernel/syscalls/syscallnr.sh | 2 --
>  3 files changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>