Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp575566pxj; Fri, 28 May 2021 10:16:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLKGYB+Qe17MbezMp/4rvjh98qI89ldG0jZuqaM8pLlZ7XYZt6rXg5MiTkOnZeZzdzDK/X X-Received: by 2002:a05:6e02:92f:: with SMTP id o15mr8192406ilt.127.1622222192119; Fri, 28 May 2021 10:16:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622222192; cv=none; d=google.com; s=arc-20160816; b=nCcrx+uNZY73CV6O+TH9putm8kOvLvUeCiqnE80R12C/6v8+pbN37rVgOLLzadB+aJ NoJMQbWxlgbZRoRmRnEt4xU3NaGRqFGmRGCETj0edd8bolED23r1HS4oqcaDeg3fP7cw 95XthqTDYHti45JS5WSZkvvcpL3qAJBfOevRWvHkRKTwmJIFVqq1wu+oErtloyXJi4qQ +DFFeranRA41FCf9waHZXsIOD4o6fpz0JHj1WchQbIHW6u8jSlJoh/wtVgAEzgXC68GF 2xz/fk+R7ONFg1HbyW++tvYl3jmxBkTEkbU6ALY64knNKQhK2ASoddda/5l6FzcEEu69 3YqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=J5iM64pg0N2uybzYQACXxrclsfRKXYPnLXXtuvP5UrU=; b=P7sjLbxs14ZffGkHt10ahRjJ+Hxjd6b6HqkqISPbF0+axK6dowK8U+M9x8kH8VqnAU GyxdopGLzawqew0Y0TlMY6NbZus0IivkrSRAookuHBO9wPqCgIUOJMxt+MSyuD7gb8U6 b2r82hoqegDqDRXc8bRPgKYm+Hc7Kf9+mnWT/r/xKmIUcbwPiLtOY1B4/pWlufwtdPd7 lQYujRgkbGy+KOc6EO7HXchFEIvsvOH5/5UUlmC7JwNmqyHNsqMwUbmrIfuTgFZZsEBz Z4ql9Q2xL684tPq0FvcDRbqVcKsIDwa1xJjhXbyuRpiXLhIS5iOntCbKnqSBzk1EkuoA oTVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si5841259iln.143.2021.05.28.10.16.18; Fri, 28 May 2021 10:16:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236536AbhE1QTj (ORCPT + 99 others); Fri, 28 May 2021 12:19:39 -0400 Received: from mga03.intel.com ([134.134.136.65]:26607 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236679AbhE1QTf (ORCPT ); Fri, 28 May 2021 12:19:35 -0400 IronPort-SDR: PAFmk1FmUEsK1sGlSYSFzvPkxcrbZmsR3un3CFcVWjjgPZJrVjDo8k2OQk2AneSrvyaa0s8RDh 0b7ptpRCBSOw== X-IronPort-AV: E=McAfee;i="6200,9189,9998"; a="203018350" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="203018350" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 09:17:45 -0700 IronPort-SDR: Ob+vocMUn0vIVMxr3+HzLdr9KZ1s3a+g+7hQqYg2H+yQ6Pjp47f/h77mkoNSN8L6USENL/3y/a APk+NyX7QZFw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="481098275" Received: from yihleong-mobl.amr.corp.intel.com (HELO [10.255.228.69]) ([10.255.228.69]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 09:17:44 -0700 Subject: Re: [PATCH 0/6 v2] Calculate pcp->high based on zone sizes and active CPUs To: Mel Gorman Cc: Andrew Morton , Hillf Danton , Dave Hansen , Vlastimil Babka , Michal Hocko , LKML , Linux-MM , "Tang, Feng" References: <20210525080119.5455-1-mgorman@techsingularity.net> <7177f59b-dc05-daff-7dc6-5815b539a790@intel.com> <20210528085545.GJ30378@techsingularity.net> <893ce8ed-df14-612b-693f-48c9dac0eb19@intel.com> <20210528151834.GR30378@techsingularity.net> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Fri, 28 May 2021 09:17:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210528151834.GR30378@techsingularity.net> Content-Type: text/plain; charset=US-ASCII Content-Language: en-US Content-Transfer-Encoding: 7BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/28/21 8:18 AM, Mel Gorman wrote: >> BTW, to do some of this testing, Feng was doing a plain old kernel >> build. On the one system where this got run, he noted a ~2% regression >> in build times. Nothing major, but you might want to be on the lookout >> in case 0day or the other test harnesses find something similar once >> this series gets to them. >> > What type of system was it? > > I noticed minor differences for some thread counts on kernel compilations > but for CascadeLake at least, it was mostly neutral. Below is an old test > result based on a previous revision. It's a Cascade Lake as well. But, I never trust hardware at a hardware company. These could be preproduction CPUs or BIOS or both, or have some bonkers configuration knob flipped. It's also got a bunch of PMEM plugged and onlined, including the _possibility_ of kernel data structures ended up on PMEM. They *mostly* don't end up there, but it does happen on occasion. Anyway, I'll see if we can do some more runs with your latest version. It looks like it's been picked up for -mm so 0day should be pounding on it soon enough.