Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp580120pxj; Fri, 28 May 2021 10:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRitat2n5LXgsSoBsxw+N1H86UZaYh4Pdjz0HC8TUSgom5BNGkWJJXM69YMuxHRRXj6PrX X-Received: by 2002:a92:1909:: with SMTP id 9mr8044593ilz.229.1622222526501; Fri, 28 May 2021 10:22:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622222526; cv=none; d=google.com; s=arc-20160816; b=gA9MJWY6ZB7jWOprER2PIX/DPkaU1pGUJ5JfBeP8i6gvB+k5ngjXGadpRkFnvkqpb8 trNGTnKBxSypcgGDrtlFf64+CEDpN6Icd4He7y6XxmpTzSzwOvqRFV9FZVJY3X/yGYPU ifhyjkKW2UKE/zbwJo3ndAIXKJkTE1pVt64bNDBvz3iCZy7Dk7LZvdIl4pmQE2as+8C1 gP0jeMnhboPOkqA9z5S8UEqTO8E36PqSZ4/4g6LC6SQ1JLmPyb7ch5XXT3QqksmmP6qW CFgge2ga+z3MCa7LUQrlifllTr6n5vklAp0qYdwLkUHDYdbPys+jWxTpVQ49FV6QC4qC l76g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature:dkim-filter; bh=6tBRoAU0JAL0auk78MYvHYjCc/y/kzmdxvTDhaug0A0=; b=hfEaNArChX2QAF3kIfNpjNigX7qKQJ04za/rMMl1jVvMtmtZ1RHsZmuQPbzUUH8LNt jmMka1856GoKHKXFFfOhI3TsCP/F1/HdDXJUQ4CuZoCDyepA11K7Wn7B4ZOTEftbu2Dt 1yMDwhCKI/LZ6aGcR0QgUQlOE4/DsK4q6ufj7Z/EMkySlpVELX8A37VnUO9d3ec2qmYu leq3YDXdttgrb4UbFCT0FI/98Oe/x/YGbJXF3zKsRS/wM9poNwi7+/38UMcyK047XAX1 s0K/noNCD8Z5wS6H9nnbcI3rakh7Q2B6e6iZHTzhRNqW1cqXS9EsxSZ5Cldplq//Wctj UzXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=u8yPVCL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c7si6665494jap.0.2021.05.28.10.21.53; Fri, 28 May 2021 10:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=u8yPVCL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235665AbhE1RSs (ORCPT + 99 others); Fri, 28 May 2021 13:18:48 -0400 Received: from conssluserg-06.nifty.com ([210.131.2.91]:35876 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhE1RSr (ORCPT ); Fri, 28 May 2021 13:18:47 -0400 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (authenticated) by conssluserg-06.nifty.com with ESMTP id 14SHGWaK005858; Sat, 29 May 2021 02:16:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com 14SHGWaK005858 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1622222193; bh=6tBRoAU0JAL0auk78MYvHYjCc/y/kzmdxvTDhaug0A0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u8yPVCL5wApWwhgUCySQ7/ahofz/JU1DW7X/fDaJPgvuuUeepHuuRUKo5uOCcEelz IUb85VQ154GZVwx5EevGPgVRAgSF0uCd/duPg75ZUiLtCzHoWkss5z94VD+tYBFUdZ a4ZssPh/LqCrM4X/Zo8r1TAzhQzgvqflcMSVcCI3kKYLZLGabDtyYAhguxhb8ei/Z2 FtTIOEc06pWfa0SENF7ScHtyovnWBV6e3CrmErua9AVehTVhZPBUFmzp73NVbhbwyq 1QqGbPEeSJLTUMFfeKJiREtoghoBvOhhJlEKRzjr8o+pymjFsWsOlB5DWPsrJu0dj3 nhZCE3CXQZbMQ== X-Nifty-SrcIP: [209.85.216.53] Received: by mail-pj1-f53.google.com with SMTP id lr4-20020a17090b4b84b02901600455effdso3758219pjb.5; Fri, 28 May 2021 10:16:33 -0700 (PDT) X-Gm-Message-State: AOAM530RJNS/wn89b0pY8R+w+MSgAf9jew0aEZEscEqGgiwCU5BzHh2p 7RJQD9TDn+daB/sXpiNdhSy0jHPE3y5f4SM1wMk= X-Received: by 2002:a17:90b:384:: with SMTP id ga4mr1261206pjb.0.1622222192405; Fri, 28 May 2021 10:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20210526173855.5963-1-msuchanek@suse.de> <20210526202825.GB8544@kitsune.suse.cz> In-Reply-To: <20210526202825.GB8544@kitsune.suse.cz> From: Masahiro Yamada Date: Sat, 29 May 2021 02:15:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Revert "kbuild: merge scripts/mkmakefile to top Makefile" To: =?UTF-8?Q?Michal_Such=C3=A1nek?= Cc: Linux Kbuild mailing list , Michal Marek , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 27, 2021 at 5:28 AM Michal Such=C3=A1nek wr= ote: > > On Thu, May 27, 2021 at 03:56:41AM +0900, Masahiro Yamada wrote: > > On Thu, May 27, 2021 at 2:39 AM Michal Suchanek wro= te: > > > > > > This reverts commit 243b50c141d71fcf7b88e94474b3b9269f0b1f9d. > > > > > > When packaging the kernel it is built in different place from the one= in > > > which it will be installed. After build the makefile needs to be > > > regenerated with the target location but with mkmakefile merged into > > > Makefile tehre is no way to do that. > > > > > > Signed-off-by: Michal Suchanek > > > > My patch was not working as expected > > regardless of packaging. > > > > Does the following fix-up work for you? > > For the packaging I need some way to regenerate the Makefile and fake > the directory where the Makefile will be on the user system (ie DESTDIR) > > Without the mkmakefile I do not see any way to do it. > > If the kernel makefile is no longer location dependent there is no need > any more, of course. > > Thanks > > Michal Sorry, I do not understand this. IIUC, this patch does not change any functionality. The generated Makefile is still the same. Why is it a problem? --=20 Best Regards Masahiro Yamada