Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 May 2021 19:26:17 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Moriis Ku <saumah@gmail.com>
Cc:     linux-kernel@vger.kernel.org, jason_lee@sunix.com,
        taian.chen@sunix.com
Subject: Re: [PATCH] mfd:Add SUNIX mfd & PCIe driver
Message-ID: <20210528182617.GS543307@dell>
References: <20210528095845.6991-1-saumah@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210528095845.6991-1-saumah@gmail.com>
Precedence: bulk

On Fri, 28 May 2021, Moriis Ku wrote:

> From: Morris Ku <saumah@gmail.com>
> 
> Add SUNIX mfd & PCIe driver
> 
> Cc: Jason Lee <jason_lee@sunix.com>
> Cc: Taian Chen <taian.chen@sunix.com>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
>  sdc_mfd.c | 513 ++++++++++++++++++++++++++++++++++++++++++++++++++++++

To be frank, this is a bit of a mess.

Let's take one step back for a moment.

Please tell me how this compares to any existing driver currently
present in drivers/mfd.  I'm 100% sure this H/W is not different to
anything we've seen before.  Thus, my advice is to base it off of a
piece of code that has been previously accepted and take it from
there.

>  sdc_mfd.h |  61 +++++++
>  sdc_pci.c |  92 ++++++++++
>  3 files changed, 666 insertions(+)
>  create mode 100644 sdc_mfd.c
>  create mode 100644 sdc_mfd.h
>  create mode 100644 sdc_pci.c


-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog