Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp696783pxj; Fri, 28 May 2021 13:21:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwY6h6XTwDKwYkVloTaKyVqb2XsYb0WbnJFV4N59CVe1b7ePe4T3BDNF/OMGxn8lEKkSYu9 X-Received: by 2002:a17:906:7203:: with SMTP id m3mr10520167ejk.381.1622233285312; Fri, 28 May 2021 13:21:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622233285; cv=none; d=google.com; s=arc-20160816; b=zpGNa2Q5PRa8NFE/E9gBD+9sXrLyYllstZOLDy+/oWcCAbIBPcBnMSbc+9WIOkRhpP 50ARaCfCZzp7E7de/RpAkK2BC5ScA1lgqmn4JgJ+baBICc8bJwEo7iNRe45djxs30eP1 XEIXZ1JIcszxkalsS4gpSC1R5bhf3y097FI+F5/RRXaWRyaPNgJ2Z3F/viGRxqggnvWR kfxK/xrRNg4df8qTdu+62PgI+SfGELxAb/dH7eazbEq+Wz84Hp07WA3eF8OOLFOK4RgZ J/yGglcKO1lYgW84gBj0E0xoZw6wvHgPmiXwdeO/Rd4DGKqvVYbQmzWeX1sx+Bb8TA7J DbqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=m/jffR89Wj+2UnPnGL84C7n5Z0dGydcl2M2L2HFj3j4=; b=VaxElFM08TWvkizU6Afc7zGgfOsgIToP8TNxYqFopU5KI9Es7Ht6hOvhJz1YNaKCfb a08nqT7fwCET4pSCFHkUIVPVcI5iegeAbXXzbdu1bl1KyIkTYd0+ULU3R7wDQgvqAmeg Qoa1VfykVLYwjxY/H15eg73LDtA4/OMMBQHPIoKADv5NMBfN7HvnhKR5uHMPQV7Es575 YWcI2L/TsvUaNbVSHFWxCjVPlOdtm4hfsBYHNmHiT/+P6QX/wuquJePKSUxFKGiV336R opO9bPYuxrMBhnZILeMC+1dVJXfC2WqiROnTJ3iVcK7eIc+9BEOvEVN/Fq+7Nydh5Urn SLtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tGBbRbyO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r2si1425281edo.101.2021.05.28.13.21.02; Fri, 28 May 2021 13:21:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tGBbRbyO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbhE1UVj (ORCPT + 99 others); Fri, 28 May 2021 16:21:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:39976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbhE1UVi (ORCPT ); Fri, 28 May 2021 16:21:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id AF7BD6139A; Fri, 28 May 2021 20:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622233203; bh=1Qp7R+3RSXiXgrS0kFmoQgrl6WbUjoVruqLmvrOIPJk=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=tGBbRbyOxyL2q/aKBn8q9p/fPs0M2ip1qicYxR15dOrNTuWou2tN+69x2YZCF9Dxj nNPR+AW8Z/0weCs0lM6xaWHUULAsE8orPSm9ATWAc/sHC++awBGNpfOUvxBf2BfIbh P3ccQ0wgmo4vhzqSCYvwhI3dufs8SEt5bN1B+HzK2io85qSOsAkZTMGRtiduoQBU+p BqL8MgoUGPkaXgTFq7+50HfUg6TtbktwEkDGiMn3nVd6O1x4RbX6FcDfItM+w6XwhD jLdY5jwLmhempeuPFqRdo0CeMbuF4VpzyUZvZz9s0irJbAuYgHCCdcExuMz+jx/uRn FSGS81PPwVvcg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 9EAC160A6C; Fri, 28 May 2021 20:20:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <162223320364.3755.2019874007174661527.git-patchwork-notify@kernel.org> Date: Fri, 28 May 2021 20:20:03 +0000 References: <20210528024356.24333-1-liuhangbin@gmail.com> In-Reply-To: <20210528024356.24333-1-liuhangbin@gmail.com> To: Hangbin Liu Cc: bpf@vger.kernel.org, daniel@iogearbox.net, toke@redhat.com, john.fastabend@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, brouer@redhat.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 27 May 2021 22:43:56 -0400 you wrote: > As Colin pointed out, the first drops assignment after declaration will > be overwritten by the second drops assignment before using, which makes > it useless. > > Since the drops variable will be used only once. Just remove it and > use "cnt - sent" in trace_xdp_devmap_xmit() > > [...] Here is the summary with links: - [bpf-next] bpf/devmap: remove drops variable from bq_xmit_all() https://git.kernel.org/bpf/bpf-next/c/e8e0f0f48478 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html