Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 -next] RDMA/srp: use DEVICE_ATTR_*() macro
To:     YueHaibing <yuehaibing@huawei.com>, dledford@redhat.com,
        jgg@ziepe.ca
Cc:     linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210528125750.20788-1-yuehaibing@huawei.com>
From:   Bart Van Assche <bvanassche@acm.org>
Message-ID: <96b606c0-ba7b-ec6a-a95f-5c579b6d02e8@acm.org>
Date:   Fri, 28 May 2021 15:07:34 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210528125750.20788-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/28/21 5:57 AM, YueHaibing wrote:
> -static ssize_t show_id_ext(struct device *dev, struct device_attribute *attr,
> -			   char *buf)
> +static ssize_t id_ext_show(struct device *dev,
> +			   struct device_attribute *attr, char *buf)

Please make better use of horizontal space by moving "struct
device_attribute *attr," to the end of the previous line. This advice
probably also applies to other changes in this patch.

Thanks,

Bart.