Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 May 2021 20:42:33 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     bvanassche@acm.org, dledford@redhat.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 -next] RDMA/srp: use DEVICE_ATTR_*() macro
Message-ID: <20210528234233.GC3874396@nvidia.com>
References: <20210528125750.20788-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210528125750.20788-1-yuehaibing@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (47.55.113.94) by BL1PR13CA0288.namprd13.prod.outlook.com (2603:10b6:208:2bc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.9 via Frontend Transport; Fri, 28 May 2021 23:42:33 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lmm7d-00GFw6-8w; Fri, 28 May 2021 20:42:33 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f43b774c-7443-4ab2-1b0b-08d922324451
X-MS-TrafficTypeDiagnostic: BL1PR12MB5159:
X-Microsoft-Antispam-PRVS: <BL1PR12MB51594E777C149126565F5C45C2229@BL1PR12MB5159.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tsPJhuQTF1pMo3YMoRgC/eZC7uObjY6IygGROlRRBeEx1L85oMBZo/JbKUN8dVV2XEtfHveip4l52wkjcnnsu7cf3vImkvURpYvOgGJY9GUqpU0CK8+9+2bc19W1lYScbEMO+DKpd9XXqoJsZlAJPItfrvNZkh3+9XU4kkVdGcdvINwNElTr/N80W22ZdST+u8qF+bOk8gCyxe0Q8+fQqKOepDCA0e/btkXYTWKU6Q0OVGp4Ga/kBbgTby0CJP3cAr905iwttAhRrFseZ9hibcs9Yu0/+dtt1UfbohMylWQauPmgDjk7HOu/wlrILc1ACqc3EOmfQ9Atr5xuqg5MXXY1EIusRGS96NkBIsgKD8Id0hRQkhU0kfZEkH+VYdnfRtc1ue1XAhqKZoDb6n0vdaPsLhgq8HtZQvI9QJPsHmlkDrmbO6nL1VlSADaFKZZ8vrRqXFrTz/HIOjVY/lfUVSTM5AmCnsnXGgkqT1nt7iANZI0pRdCqfxZDREHFH4S7Gmn9xSxaMu1cw9DC/jGajiwjdcevHSmxKQXH5KAAhfnDvHvHRaUfp3+aiyGYBjWt4MQbY6ebv3kmVr9BvaJF5WN3jUu/jfzWpM6biRdFcB8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(86362001)(83380400001)(8676002)(6916009)(316002)(2616005)(186003)(2906002)(426003)(1076003)(66556008)(66476007)(66946007)(26005)(5660300002)(33656002)(38100700002)(9786002)(9746002)(478600001)(4326008)(4744005)(36756003)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?i2Umf3w6ryISKCz9x8BjUk3IjfOlqR/tgLF0ZUmjkTM07oGldEBzmM269DHT?=
 =?us-ascii?Q?Eb8K9asXfOhGliIagY/cQuHGy7zc6+nRF2h/Fzi5Ze8dP0qfXPU33pCNAH7E?=
 =?us-ascii?Q?ZBWZovWaolx0rSxUXu1zhBvQw1NPjoIMKLkkxV0asBzUGsNh0I/d6Legjxq5?=
 =?us-ascii?Q?GM+fUFeEDWFUfG+FSw7ACW92iGyDKgtuaTkuGUZ0k4dOg78Eifp2Et6leDV+?=
 =?us-ascii?Q?UdJfbyIpH8JhlGWnKF0XVEFj5thbsHE5ZYFGOvbFoQyu0FR4GJkBRTXXeSq4?=
 =?us-ascii?Q?7ESQ9D5MheNbKJP8A5RBRrXD36uqnfa3NxAuwkXuHhj5GPN4mJOaPg+5PCQm?=
 =?us-ascii?Q?1OTYfJJp2taP6p0qlUnocqbGdmV8DY7pp9+yKaVN9eRzs3FfTernJ6w2N1Yq?=
 =?us-ascii?Q?nSHzllNYadL8psPXlj+8oJSPKaq8i0Lnj37+QLAW6gyX0UUClo+lOrOBaJVV?=
 =?us-ascii?Q?pKRyVKNaRsJ2lX5yRr6RWiaPYGgMJ6chuRTfP6iKyQv756rk99i4wE7Csg8Y?=
 =?us-ascii?Q?LWtC1FoQwtJrJtRIf/OHc7dTtnjepEZ6Gk+Uzxjj7e9A1yU62h3YA59jD5Ko?=
 =?us-ascii?Q?vqgRETAEN3x/hpFKRXzjL5BSbujZXnT+xS5EfNiFPHMWixr6lcEV9ZeTu8gZ?=
 =?us-ascii?Q?ErhZYVSmzWSJ6r/vmSvcHij/AVXxMpBfbQGKnQZ/nYjxbaiFFTHWQqjPsLCH?=
 =?us-ascii?Q?KLZhGmbdIb3SIUkGpdeity7YIY0tzZ10wg4+KfhO40Tie2QUivewr1rIoetS?=
 =?us-ascii?Q?2mZrqoc8LL58tAjVGPjdCAjoy3A7yZYt3m2wqj66DebyUb8M2E48iXHvus3E?=
 =?us-ascii?Q?IoFP/VYjNsxJ3IHUPSSM7K1wp6P8IMa165vUIZODWdhlr8iE8q9Y6nBtZpkw?=
 =?us-ascii?Q?y9y6t07cbmzEsuBaJoqfkIzdWM73Iuin+POHVh6mZLe6aPYDHq5AATRzErJw?=
 =?us-ascii?Q?Q1KDfmt8A1Q+2kt0PynsFT6lYnRI2cSKLxG0y9Qt4FCVCUOabBsb+JE4lXOL?=
 =?us-ascii?Q?IIdjAkRM3YPEm6IJF7RUPO1ohzpbslODdmGyK5XXM6kpFCCgDTR866IlLjT8?=
 =?us-ascii?Q?2si13hfZIoXerOwn7FvmjdEClZFB8gEDE/3hdCVJzjFRp+Lg0ywzDlAKRQ+Q?=
 =?us-ascii?Q?cZmVeeu0Wd0ac7QDTd9IEpi4680opSO4HxtBfmdPSbcDyyHIkKmJI8sMx08L?=
 =?us-ascii?Q?jt9UTC3xkE7AzQch1nkYeAM1RVImRDi4MROAPPv9EdInUdXf0Mp3y0Mu+prQ?=
 =?us-ascii?Q?kT61nU6034gqQrGGMrFs1IIZz2RrcxfMt+oRTWhmxlEPzT1+o6XbMl5xSVrY?=
 =?us-ascii?Q?WNruPjC9KXoA6X1/rMnj0BE3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f43b774c-7443-4ab2-1b0b-08d922324451
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2021 23:42:34.1104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /fiHYshrufFQ30wtz6Tjn/5h7zxPhiqL38CjRwvmzBOG8asmRempNOLxszGlLDSB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5159
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 28, 2021 at 08:57:50PM +0800, YueHaibing wrote:
> Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v3: rearrange attrs
> v2: convert show_port device attr
> 
>  drivers/infiniband/ulp/srp/ib_srp.c | 109 ++++++++++++++++------------
>  1 file changed, 62 insertions(+), 47 deletions(-)

Applied to for-next, again with clang-format

Thanks,
Jason