Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 28 May 2021 21:51:30 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: Fix debugfs_read_file_str()
Message-ID: <20210528215130.19523600@oasis.local.home>
In-Reply-To: <20210527091105.258457-1-dietmar.eggemann@arm.com>
References: <20210527091105.258457-1-dietmar.eggemann@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 27 May 2021 11:11:05 +0200
Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:

> +++ b/fs/debugfs/file.c
> @@ -893,7 +893,7 @@ ssize_t debugfs_read_file_str(struct file *file, char __user *user_buf,
>  
>  	copy[copy_len] = '\n';
>  
> -	ret = simple_read_from_buffer(user_buf, count, ppos, copy, copy_len);
> +	ret = simple_read_from_buffer(user_buf, count, ppos, copy, len);
>  	kfree(copy);

As we have:

	len = strlen(str) + 1;
	[..]
	copy_len = strscpy(copy, str, len);

I can't think of any situation that len is not equal to copy_len + 1. :-/

Anyway, either "len" or "copy_len + 1" would work.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve