Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1045561pxj; Sat, 29 May 2021 01:17:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxp0Ni0/fBiTgStvlvvR8gF8u3QPdH0UAopvQMkiqXrRTgW2ngb86/lIr8PlFtiBbHiCGg8 X-Received: by 2002:a05:6638:635:: with SMTP id h21mr12174047jar.135.1622276247357; Sat, 29 May 2021 01:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622276247; cv=none; d=google.com; s=arc-20160816; b=1EARp8w3t55RLNh0v7mWAUJ+4dQJk3+m3yLEWNjmPtcCw93d/rZM/+9ObUOnBlezsF 3zibYxhx58Pfa6EkkSQ4nZRDu1+x65N/eLakI4P5XHxREy6tamtppK58jPd5OvWY6XBu 8haoWWB/7hXGFe5wNIDasSw1ALvyXzZNtRDd6bSa+qybSkIupYJ8TguSs62POO4HB5ao yfKgGT/rwnRZhvXyrQNViRXSyYyDEuxTIdndZllDq2RH/G5Zq1DbXD3TeQGGxjYG5xBR x7vl8n3SCIIfOlWxa1BvEuf6rPkD1hvkdNCw83h4cFQRB/wHUNQl/TFqVWwqWmOjGmm8 Djgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=6G8sFPLlvzuI12KHuaFKGtBK/AGm0ACWnvgrOUETjWs=; b=nSw5smPcCfJHaQFWaECIDTgLC5bQtWIvM0qvGMz7601FZ3sixZRi0mUN0AwftEG+Jc yBx9UywsjSBjKx060BUTvCcAbh1vV9Qpz6bQkw9xosvDu745fkr8uvk7d3CCBKZgHJWr 71C6xSc/Odd8Wu5ZIrBla7TykUsHLJTDsmEnzue42jiZcmN3M1iivyXC2eO8nmtiEXVZ 89JQ2u/YNbBpsJrRyiZo5XqrTFBw+4lO/391uqPtVMLUaLUogvFRh5N2wvVcIKGcsl28 WexvozkHexW5RNGlm9b/4739HKM1rsOWJ7mvKMZZCD2S5JFqqljrJ4bJeI1FyhixzD0d mm6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si10195760ilm.103.2021.05.29.01.17.13; Sat, 29 May 2021 01:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbhE2ISL (ORCPT + 99 others); Sat, 29 May 2021 04:18:11 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2528 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbhE2ISK (ORCPT ); Sat, 29 May 2021 04:18:10 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FsZ7y1Gs0zYr34; Sat, 29 May 2021 16:13:50 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 29 May 2021 16:16:31 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Sat, 29 May 2021 16:16:30 +0800 From: Yang Yingliang To: , , CC: , , , Subject: [PATCH -next 1/3] cifsd: fix memleak in ksmbd_vfs_stream_write() Date: Sat, 29 May 2021 16:20:56 +0800 Message-ID: <20210529082058.3012233-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before assigning wbuf to stream_buf, memory allocate in ksmbd_vfs_getcasexattr() need be freed. Fixes: f44158485826 ("cifsd: add file operations") Signed-off-by: Yang Yingliang --- fs/cifsd/vfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c index 291953eff5fa..9057b30278b9 100644 --- a/fs/cifsd/vfs.c +++ b/fs/cifsd/vfs.c @@ -429,6 +429,7 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos, if (v_len > 0) memcpy(wbuf, stream_buf, v_len); + kfree(stream_buf); stream_buf = wbuf; } -- 2.25.1