Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1085009pxj; Sat, 29 May 2021 02:42:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVyfOR9XpPUgndrHAjAkwEUB1LdMKxcg+1ZgPHFHQZGlWB30tpnn9tvqoep8byTEPWZ734 X-Received: by 2002:a5e:930e:: with SMTP id k14mr10337914iom.136.1622281362168; Sat, 29 May 2021 02:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622281362; cv=none; d=google.com; s=arc-20160816; b=z6pwrDj7TJS+xhCF0f0hLKJ6IUr9tR0xKKddOmVpczSsX6+9dW/jqNRPLuOGPdHIPh mlKbYjz9oA3IO1G2d+I0lB7yPSAQaGk5RRJN2Jh59VrXaZwFutCVVcBQK4WNdcMf0lUX s6Rtsfbzga/1/Su49gslefIx8X9E1AOrqFLWrJkR0Iz8qJZ4wvpbE/1oU+Voq3TTBPnH Oxanyv1E0ylCLZeybwfzA1NE/XVRdW5guWnekLBgZzWOIjDcNFjdFwQyWiOz/lG5/f0x KVlOLFm5+w7tvNa8EcbFaqiL7BhebQZdPDPkcpCo6JNNONB0P0q3YYpevmjGYJGgdAig 6pfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BhmzpOge1ugSk/b76qU2OK3P2aRPPQAhF5XEsVbHEOQ=; b=giiQ4nX8WpXbcX6NhzVZ2aHLifCpV4z72UU4OTPEcuZ8tmt7t9rNoFfImW5a58CBK0 jd2YH1hntlv3Fmymw6ttsw/GxZSxRmWDBsQE755Nyv2e4Ifo76iwmIYyEUOOcaDf8GZ7 XYSr0uZyNUBW9kZUkAtxVknN/WQXlwNTQvfGP0MX16kgTfSR+vMiJPK0V+xeECkXEIsC 6L58o3IBb3fiwFCUjynhfLCL1coEMYhrVjpO5YN+IQHzviwgYr0ooXK1It4o8POguFi4 +hoGWb4UbCn1UsSxd1zfP1CCpOfs0xC9BJI9LfMeRLxinq/Uyy629kOIAUHI3U0mww/F Cvpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jWnNbjNC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w7si10528172ilu.149.2021.05.29.02.42.26; Sat, 29 May 2021 02:42:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jWnNbjNC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbhE2Jn3 (ORCPT + 99 others); Sat, 29 May 2021 05:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhE2Jn1 (ORCPT ); Sat, 29 May 2021 05:43:27 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25026C061574; Sat, 29 May 2021 02:41:49 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 6so4410052pgk.5; Sat, 29 May 2021 02:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BhmzpOge1ugSk/b76qU2OK3P2aRPPQAhF5XEsVbHEOQ=; b=jWnNbjNCBpqvtp3i0o1QlrRtBsElXIXxM1qT5bC8x3ntyAXoAEgIuL2s39KnbAB6ty qqHNm7KQypc4KlHN5TYbIP8UHN3whNnVQRUqemJY7aXnDyBQAtNQNh4M4V8fgM9RqITy VYm0H7RJNITZ+Uv6iXIZNQfLIIEzF7pn2fsDmmTE2IOONX43Ji6/uVZ1scbO+NSQZuF0 2pjF74bycvRGviW6R8n4yKxQ3gPZ0uT/7f9M00X1QlJtkyJgfngB7i88jOVQumnot7+7 j+1t+F/CDvOilk+XuvTx445nbuyAXUAUd2lnOZcVaLtxgPl18LQT5EQU2Q/X25Jrg7Et RmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BhmzpOge1ugSk/b76qU2OK3P2aRPPQAhF5XEsVbHEOQ=; b=F/VP2muPLP9fBqXO9V5iKzUcPzNV2g9ygfnKWcQenagEjNZv/q+EK+1oxY/uINvnh6 GLUgL2UHQbrGV7HL4u6VvIGrVSls+Ii5wDB4ICBmW3GVzbZlH5b8nqo9H6sx+Z559WRj GCmAO1rvAVxxai/oNxjgxlIZ+YoO6e/tFzOeoPPmxRBVcusxZK4vW1m09mCFfrkGkGhR uRppcDBQSDxU5o4MJA2NtTWq1Xz8fo6mm//UBGq0oO+YIgDObSWIaviV51rSIe+RzwCF 75WegRLWm21fTygH9ImqEq+oMYaxOdOOsWv9BhjeEs2BljDtRqPMJEIU72Lbtfj1cqAu krLQ== X-Gm-Message-State: AOAM532BS8iDEeAYgyFwktvrfuzGZqJ03rbvksMewN5mG0IHGsFhKSc9 599EusQtIWLzXOaEmalOOWRmpxDIW8ZSapdT3QE= X-Received: by 2002:a63:4145:: with SMTP id o66mr13231146pga.4.1622281308767; Sat, 29 May 2021 02:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> <20210510095045.3299382-4-andy.shevchenko@gmail.com> <20210528100440.GE2209@amd> In-Reply-To: From: Andy Shevchenko Date: Sat, 29 May 2021 12:41:32 +0300 Message-ID: Subject: Re: [PATCH v1 03/28] leds: el15203000: Give better margin for usleep_range() To: Pavel Machek Cc: Amireddy Mallikarjuna reddy , Linus Walleij , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 1:46 PM Andy Shevchenko wrote: > > On Fri, May 28, 2021 at 12:04:40PM +0200, Pavel Machek wrote: > > On Mon 2021-05-10 12:50:20, Andy Shevchenko wrote: > > > 1 microsecond with 20 millisecond parameter is too low margin for > > > usleep_range(). Give 100 to make scheduler happier. > > > > > > While at it, fix indentation in cases where EL_FW_DELAY_USEC is in use. > > > In the loop, move it to the end to avoid a conditional. > > > > Its not like unhappy schedulers are problem... > > Any hints then? To me it sounds like torturing scheduler is the real problem > and that's why scheduler is unhappy. Okay, I have rephrased the commit message. -- With Best Regards, Andy Shevchenko