Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210510095045.3299382-1-andy.shevchenko@gmail.com>
 <20210510095045.3299382-12-andy.shevchenko@gmail.com> <20210528100906.GG2209@amd>
 <YLDKneVl0DefNdAW@smile.fi.intel.com>
In-Reply-To: <YLDKneVl0DefNdAW@smile.fi.intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 29 May 2021 12:46:43 +0300
Message-ID: <CAHp75VcnKJj_2G5xiBXCGQmo3XqV=jR1J64zoimiBr162rw+DA@mail.gmail.com>
Subject: Re: [PATCH v1 11/28] leds: lgm-sso: Remove explicit managed resource cleanups
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        =?UTF-8?B?TWFyZWsgQmVow7pu?= <marek.behun@nic.cz>,
        Abanoub Sameh <abanoubsameh8@gmail.com>,
        Dan Murphy <dmurphy@ti.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, May 28, 2021 at 1:50 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Fri, May 28, 2021 at 12:09:06PM +0200, Pavel Machek wrote:
> > On Mon 2021-05-10 12:50:28, Andy Shevchenko wrote:
> > > The idea of managed resources that they will be cleaned up automatically
> > > and in the proper order. Remove explicit cleanups.
> >
> > Are you really sure this is good idea with the regmap_update_bits in
> > between?
>
> Good question. I will check it.
>
> > > -   /* unregister led */
> > > -   devm_led_classdev_unregister(priv->dev, &led->cdev);

I left this untouched, i.o.w. no removal in v2.

-- 
With Best Regards,
Andy Shevchenko