Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: Memory uninitialized after "io_uring: keep table of pointers to
 ubufs"
To:     Andres Freund <andres@anarazel.de>, Jens Axboe <axboe@kernel.dk>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210529003350.m3bqhb3rnug7yby7@alap3.anarazel.de>
From:   Pavel Begunkov <asml.silence@gmail.com>
Message-ID: <d2c5b250-5a0f-5de5-061f-38257216389d@gmail.com>
Date:   Sat, 29 May 2021 12:03:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20210529003350.m3bqhb3rnug7yby7@alap3.anarazel.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/29/21 1:33 AM, Andres Freund wrote:
> Hi,
> 
> I started to see buffer registration randomly failing with ENOMEM on
> 5.13. Registering buffer or two often succeeds, but more than that
> rarely. Running the same program as root succeeds - but the user has a high
> rlimit.
> 
> The issue is that io_sqe_buffer_register() doesn't initialize
> imu. io_buffer_account_pin() does imu->acct_pages++, before calling
> io_account_mem(ctx, imu->acct_pages);
> 
> Which means that a random amount of memory is being accounted for. On the first
> few allocations this sometimes fails to fail because the memory is zero, but
> after a bit of reuse...

Makes sense, thanks for digging in. I've just sent a patch, would
be great if you can test it or send your own.


> It only doesn't fail as root because the rlimit doesn't apply.
> 
> This is caused by
> 
> commit 41edf1a5ec967bf4bddedb83c48e02dfea8315b4
> Author: Pavel Begunkov <asml.silence@gmail.com>
> Date:   2021-04-25 14:32:23 +0100
> 
>     io_uring: keep table of pointers to ubufs
> 
> Greetings,
> 
> Andres Freund
> 

-- 
Pavel Begunkov