Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1145763pxj; Sat, 29 May 2021 04:47:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw2xuis6kd/DdZwuNDcgL741yiXYI5OojMf6U2/W8tZcvIlQIiW1RuXb9DiGuQtJAso86X X-Received: by 2002:a05:6e02:1d1a:: with SMTP id i26mr10962184ila.180.1622288843487; Sat, 29 May 2021 04:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622288843; cv=none; d=google.com; s=arc-20160816; b=Xkhzqsvmg13xY5UDonmgWXSsIK3duAGov77EmYvVZDPcQHYXS6IuBGcg3duaGyHpv6 N1YT9Y8MhtwhmWlixEgC1+1+Bpj2tMAFIvPMd4r+AD5GS32W0ddotQDZwOE9bPQMk45g xvOHZmAzxLaxWjeUwCDIu8OhdRAPa5UO7EYyUE4sqGP11HapFkBg2dZy0BgUDMgOpPP3 ohO2oTexETU10jMmAa8BCAkdDsFzPzPFgIOdSyFdzTfB5e165mtyhYPxJCF3ozllLmbn PDrCRG1bH9t/RnS+ttrs7eu73y8Icgvrxs2mXr1oCS/0coli7XjxGPAQ0m+o7dE8joGz rLDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=oWDMJUSqmjemPZMvB0Hxj9Ex29UjJIennNl64ZZTfhU=; b=VHHKH6XvQBXaJnAZ3MSAnglQ88MQ6TceLVKm1/FJ2gGBB21i0JPg/qXpg62Evi51Na E43R2tZvy1G/ZpyaHiGa0A7lShmruVASCIdgn5e+UX3dgKuB7v25VJGDQDJXpDuXkpYl SMnBBHa2ZDgGFFOVpfrmr8HMFwmszdYLj8sJs1IrYBXXL/A4tDmJ4VoyHGNC3rz2PykK zzrCSHE6FwcKhLBzNadL6THXSM5hMjvSO7ES03vwqX3gEXlLvkxm+leOWca4NsE9qkif 6dwnH2EeOaLTlRrnfmbk1wHjDQkzzePsazXepOb8Sjq+sfR+kkT9lj1hmdKWJ7TlNTbD 9RFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si2275239iln.17.2021.05.29.04.46.57; Sat, 29 May 2021 04:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbhE2Lqa (ORCPT + 99 others); Sat, 29 May 2021 07:46:30 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2469 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbhE2Lq3 (ORCPT ); Sat, 29 May 2021 07:46:29 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Fsfm43Bv4z681J; Sat, 29 May 2021 19:41:56 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sat, 29 May 2021 19:44:51 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 29 May 2021 19:44:50 +0800 From: YueHaibing To: , CC: , , , YueHaibing Subject: [PATCH net-next] net: hso: Use BIT(x) macro Date: Sat, 29 May 2021 19:44:21 +0800 Message-ID: <20210529114421.25480-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BIT(x) improves readability and safety with respect to shifts. Signed-off-by: YueHaibing --- drivers/net/usb/hso.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 63006838bdcc..2587f8f52226 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -163,13 +163,13 @@ enum rx_ctrl_state{ #define W_VALUE (0x0) #define W_LENGTH (0x2) -#define B_OVERRUN (0x1<<6) -#define B_PARITY (0x1<<5) -#define B_FRAMING (0x1<<4) -#define B_RING_SIGNAL (0x1<<3) -#define B_BREAK (0x1<<2) -#define B_TX_CARRIER (0x1<<1) -#define B_RX_CARRIER (0x1<<0) +#define B_OVERRUN BIT(6) +#define B_PARITY BIT(5) +#define B_FRAMING BIT(4) +#define B_RING_SIGNAL BIT(3) +#define B_BREAK BIT(2) +#define B_TX_CARRIER BIT(1) +#define B_RX_CARRIER BIT(0) struct hso_serial_state_notification { u8 bmRequestType; -- 2.17.1