Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1157106pxj; Sat, 29 May 2021 05:07:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwROdt5ExUTJLERxfvHCrdWxToy9B4+DHyXrDWv2vZZrMvMWcpU8IjioLs+5pgH3Co9StJ X-Received: by 2002:aa7:d294:: with SMTP id w20mr202708edq.229.1622290073116; Sat, 29 May 2021 05:07:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622290073; cv=none; d=google.com; s=arc-20160816; b=hy5fYJS6C0ftyu0S4MRV8grxJc8vcz8HqTlJy0A1CLp48LvTCa6NVRfWpDmEHx+znu zQMpdv9S3A0LHtjJ5oUBNq6e5+W0P1M09xnCzFpUsty/icXeW5YynWp+a+Vs0A0igXij JWScc2UxZkJaHt/GEb48TnO30glKqy4y59/WE3dSowIaZo93Ynkn1yXqbwcyjr7NwbDZ rDKql1VKjyGDfrnZbf123arIFpdK4Dgz5mDc26k9jSfXW596B5O/XdiFWerbxrlb4F87 bqU8xsBnoDup/1N6h3VArCv4BWhDjGghnKn4zud5RAf7uVcornM7GcmimL1xhOayqd+K a5lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=cCZee+L+Kd5FDXuZdNJ+ASpQp2riJPRN+Zgz0CJItS4=; b=kwql0AdSFU+WAmTSaRsv4GNSYVl8Mcn3dzqZBXe/TN2LVe+HP445+gHjWP/zpYeovI skQWsnjU50pGJhryODfmulCoKvPekSSuSmBtliLXtvZ5bc/GY4RLvW9+brLksI7OYWH7 S4sbK6fodcvh4HYvfyuxATLtqoPxkn97G0zQDuyGBd9nx2alqDtwEdC/xRh2e4qCiEF3 LVEbdJMAXKRnT3iUBrvxs2rrIVRHCiHIRyQdTSApLg1dgUkb2XwohWmH3batO4/6IOm9 tG/eMe5lNKsUoukzJU1O65+LUNBts1KRKMzrQroFm3cHddini+Gb6xUT/vDQ/74UxXZk d4ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si7685476ejg.296.2021.05.29.05.07.28; Sat, 29 May 2021 05:07:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbhE2MHB (ORCPT + 99 others); Sat, 29 May 2021 08:07:01 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2470 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbhE2MHA (ORCPT ); Sat, 29 May 2021 08:07:00 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FsgCl6qnYz689v; Sat, 29 May 2021 20:02:27 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sat, 29 May 2021 20:05:18 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 29 May 2021 20:05:18 +0800 From: YueHaibing To: , CC: , , YueHaibing Subject: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare_buffer() Date: Sat, 29 May 2021 20:04:08 +0800 Message-ID: <20210529120408.23456-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A coccicheck run provided information like the following. ./drivers/usb/gadget/function/f_fs.c:3832:9-16: WARNING: ERR_CAST can be used with data ffs_prepare_buffer() should return an ERR_PTR() encoded error code on failure. Signed-off-by: YueHaibing --- drivers/usb/gadget/function/f_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index bf109191659a..cb419bbd089c 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -3829,7 +3829,7 @@ static char *ffs_prepare_buffer(const char __user *buf, size_t len) data = memdup_user(buf, len); if (IS_ERR(data)) - return ERR_PTR(PTR_ERR(data)); + return data; pr_vdebug("Buffer from user space:\n"); ffs_dump_mem("", data, len); -- 2.17.1