Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1361821pxj; Sat, 29 May 2021 10:57:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwKrcthfeFbtRE6UZAdFFATRY1GqOvy9py1Jy0nut1KMGdvzpgtPfAtlJ7Xa/dQ6gZaKTz X-Received: by 2002:a17:906:4747:: with SMTP id j7mr5828805ejs.419.1622311034094; Sat, 29 May 2021 10:57:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622311034; cv=none; d=google.com; s=arc-20160816; b=zTJnq5wc0THJXfJ3hJwzT2f0YWyIEio3VD72eO0A7YPDtE2ogRARQiAw/BoABj0eI9 Bm84JQ5oojOdLO3x2WJAiy2SAL9Pz3obFKZAuUxaLzDxodIrgQg3EsSWL6denIO+Pw1w aAhc7Ck4gtVTRowS3GMjebG3EmokUB4ZTi+QrseoJGbpFaEeS8RTxvqG4doa174fyXDE kpXxNSFERo4MEZ4QR3iLJp6mue+F1TZY9WAZagESHg5rYP+UkSDkus1lM8DYwFfTYxeH waYUL+FYPsdgPEgSaebbRE1t9oMTlbgAi71FlrjAsTvXxmLHVxvqOkU5voGeOMAYjyYj iDrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=lBv+CDAZmly+YXvM7KIYOQ+467ancMAhMJppKF+d5M8=; b=uf5r1iDiOO0X05PHkP5N10yBLu73PlnM5wlrZ1MrLW7Lz94ppTUN7VX+Ii5bkGkwMC o9THQkXbaaPMeFRk5m3Ww8tXMnhDLb7iSUFbuyiEu1zfMttBshslZ+PdQw2sNDGcXN+k JaSgw7nw71ufYuKddZYpT535REZz+QfWXnYzn4Fyv59+Y2iJRE7HDF7A67of5ZVl5HU9 ZbiwDcghDQzNlXHTFmXDHLvRdCenTK6bI+tTihAGsx2U712hqvhhb8xjksn7mbBNzmuN iNJHfBicpETncNgY3IUcwJ1UWqG6fs8ve9UINgcYjrsFd3mvgB939BXTmkpwPWIzEgC3 t5rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s15si8067362eji.457.2021.05.29.10.56.51; Sat, 29 May 2021 10:57:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbhE2R5i (ORCPT + 99 others); Sat, 29 May 2021 13:57:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbhE2R5h (ORCPT ); Sat, 29 May 2021 13:57:37 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3D7C61059; Sat, 29 May 2021 17:55:59 +0000 (UTC) Date: Sat, 29 May 2021 13:55:58 -0400 From: Steven Rostedt To: Pavel Begunkov Cc: Olivier Langlois , Stefan Metzmacher , Jens Axboe , Ingo Molnar , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] io_uring: Add to traces the req pointer when available Message-ID: <20210529135558.7ec54cb7@oasis.local.home> In-Reply-To: <6fd74635-d3a8-7319-bcc6-c2c1de9c87ee@gmail.com> References: <60ac946e.1c69fb81.5efc2.65deSMTPIN_ADDED_MISSING@mx.google.com> <439a2ab8-765d-9a77-5dfd-dde2bd6884c4@gmail.com> <9a8abcc9-8f7a-8350-cf34-f86e4ac13f5c@samba.org> <9505850ae4c203f6b8f056265eddbffaae501806.camel@trillion01.com> <20210528184248.46926090@gandalf.local.home> <6fd74635-d3a8-7319-bcc6-c2c1de9c87ee@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 May 2021 13:30:31 +0100 Pavel Begunkov wrote: > io_uring offers all different operations and has internal request/memory > recycling, so it may be an easy vector of attack in case of some > vulnerabilities found, but nothing special. As that's the status quo, > I wouldn't care, let's put aside my concerns and print them raw. There's a lot of information that the tracing subsystem gives that would help several vectors of attack without the need for pointers. That's why there's a lockdown method to disable all tracing. But the tracing system is also good at finding out if your system has been compromised ;-) -- Steve