Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1375242pxj;
        Sat, 29 May 2021 11:23:21 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzy57ht8txIv5ueavwc3AKwsdR1i5KheKIjn2SK36vIStwltZYGy2GX4Zu2dzNpzQABVQJb
X-Received: by 2002:a17:906:c14b:: with SMTP id dp11mr15019480ejc.351.1622312601307;
        Sat, 29 May 2021 11:23:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1622312601; cv=none;
        d=google.com; s=arc-20160816;
        b=DgcrpITgXyeJM09QHv6uwPqk9lXjmIbYLnvqf9QpB9Kjfz80tdQ4JI3moVC+J1e94Z
         HV9FGp3UQaFXyzdtoS6szXDNDYdeoHtzp3ixO9U3CaQ+sBznej5yVyzZ2CRd8D5/ATOi
         U7melPkj+3S7jO3m+yq/1RYYpLPlrDJ7eMqFj//0qU34oRAPtHW5npZqj8iRomK+JsKU
         mm7BcRq9ECqM+nY4wy4LIbjj1shmVIYa6RuZt/NCQu1fkCangShNTyPUbCXRzDTVctg7
         Ql84wCXtmlM2+LmQmnJUqX15HTTY96rOtA2W9gDlokvmZ6iy07XCspzQJiD0PfNr6kZO
         TQIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=5Qdz461gMcaT09Lh5nRC5Tb/An/G/cXNZMLamFs1vJ8=;
        b=Q+eKPOLKpCIOEHwSwjopchJBAYIhCyF28Qbqes2ew/BZl9HZk8kRfm1ZrggAoUzihh
         LCCrJrEiVxe/QfY3bIJxqgu7MMcKL4ZsY63JCq0t0AU3wJORnZQbH4d1+BpSFzqH41fK
         l5IwYAViJ8mLi6WIade7M7AVa1ehyPwQSrk51c14dRjxBIUMos44TZG5uCXGPUIalFpT
         3J7gdtlv9+a+oBjJDH9OJXSRxx1vPDmNdRy8Ro17ZnDLRLbS6pCWawYIcmZA1qUOrUel
         Y17j22Wy00J6pVcd7itreB1rtz6nI9bTZ4UTCkoBX/DGWRBu3qcJvNsEkWo7WwdoMzWa
         d5xg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGvwISJw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id b10si8021347ejd.716.2021.05.29.11.22.37;
        Sat, 29 May 2021 11:23:21 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGvwISJw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229789AbhE2SK0 (ORCPT <rfc822;lukasz.wituch.linux@gmail.com>
        + 99 others); Sat, 29 May 2021 14:10:26 -0400
Received: from mail.kernel.org ([198.145.29.99]:44768 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229726AbhE2SKZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 29 May 2021 14:10:25 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B2B361153;
        Sat, 29 May 2021 18:08:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1622311728;
        bh=5Qdz461gMcaT09Lh5nRC5Tb/An/G/cXNZMLamFs1vJ8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=aGvwISJwdQSEUTZ1W21Ne/p0qVOT1HSliRX1SJiUdEHhYZ1LLC9P+z/Xcqq88+jsy
         xVtlgnndaeVtwwNCnWVc6XCy8bDz17gMgNwruR+9BmJZFKDt1PJxnDcyON3dWZlsC1
         wSsmtdF3+PUpvmntQxliCDnmIYDUDXffAALr6nI6Kr2vclgEzKIdm4E+pd78+58EPF
         xT1ZYcbBwqbw1VABRj6Gt49JGuhKlwd62Clp+Xana6hw8q379k6NxLRqYv1w5QtZtL
         OfROJ7fGf1Pa0kvFdbOCAXP+pB4wtXZXVWdwQHg+yIV5UU/m9iVpR3lRI+RIcIax2E
         InTnOJevhKr9w==
Date:   Sat, 29 May 2021 11:08:47 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] pktgen: Use BIT(x) macro
Message-ID: <20210529110847.53473ab0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20210529114559.24604-1-yuehaibing@huawei.com>
References: <20210529114559.24604-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 29 May 2021 19:45:59 +0800 YueHaibing wrote:
> BIT(x) improves readability and safety with respect to shifts.

Some developers prefer not to use BIT(). I'm not applying these.