Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: jackp=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A3833C433F1
Date:   Sat, 29 May 2021 12:24:21 -0700
From:   Jack Pham <jackp@codeaurora.org>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Wesley Cheng <wcheng@codeaurora.org>, balbi@kernel.org,
        gregkh@linuxfoundation.org, agross@kernel.org, robh+dt@kernel.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v8 5/5] arm64: boot: dts: qcom: sm8150: Enable dynamic TX
 FIFO resize logic
Message-ID: <20210529192420.GA11263@jackp-linux.qualcomm.com>
References: <1621410238-31395-1-git-send-email-wcheng@codeaurora.org>
 <1621410238-31395-6-git-send-email-wcheng@codeaurora.org>
 <YLJ000lIVhZM5WEV@builder.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YLJ000lIVhZM5WEV@builder.lan>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Bjorn,

On Sat, May 29, 2021 at 12:07:31PM -0500, Bjorn Andersson wrote:
> On Wed 19 May 02:43 CDT 2021, Wesley Cheng wrote:
> 
> > Enable the flexible TX FIFO resize logic on SM8150.  Using a larger TX FIFO
> > SZ can help account for situations when system latency is greater than the
> > USB bus transmission latency.
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> 
> Based on my previous request of always adding this for the Qualcomm
> platforms that supports it, which is implemented in patch 4, I don't see
> a need for this patch.
> 
> Am I missing something?

Looks like Wesley had quickly sent a V9 of the series right after V8,
and the DTSI change is dropped.

https://lore.kernel.org/linux-usb/1621410561-32762-1-git-send-email-wcheng@codeaurora.org/T/#t

Thanks,
Jack

> > ---
> >  arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > index 51235a9..8f532cb 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -2275,6 +2275,7 @@
> >  				iommus = <&apps_smmu 0x140 0>;
> >  				snps,dis_u2_susphy_quirk;
> >  				snps,dis_enblslpm_quirk;
> > +				tx-fifo-resize;
> >  				phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
> >  				phy-names = "usb2-phy", "usb3-phy";
> >  			};

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project