Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 29 May 2021 21:55:48 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mikelley@microsoft.com,
        viremana@linux.microsoft.com, sunilmut@microsoft.com,
        wei.liu@kernel.org, vkuznets@redhat.com, ligrassi@microsoft.com,
        kys@microsoft.com
Subject: Re: [PATCH 12/19] drivers/hv: run vp ioctl and isr
Message-ID: <20210529215548.okh67gtegsa4fd7r@liuwe-devbox-debian-v2>
References: <1622241819-21155-1-git-send-email-nunodasneves@linux.microsoft.com>
 <1622241819-21155-13-git-send-email-nunodasneves@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1622241819-21155-13-git-send-email-nunodasneves@linux.microsoft.com>
Precedence: bulk

On Fri, May 28, 2021 at 03:43:32PM -0700, Nuno Das Neves wrote:
[...]
>  int mshv_synic_init(unsigned int cpu)
>  {
>  	union hv_synic_simp simp;
> @@ -30,7 +126,7 @@ int mshv_synic_init(unsigned int cpu)
>  	*msg_page = memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT,
>  			     HV_HYP_PAGE_SIZE,
>                               MEMREMAP_WB);
> -	if (!msg_page) {
> +	if (!(*msg_page)) {

This hunk belongs to the previous patch in which you introduced this
function, not this one.

Wei.