Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Sun, 30 May 2021 11:52:27 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     <jasowang@redhat.com>, <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] vdpa/mlx5: Fix umem sizes assignments on VQ create
Message-ID: <20210530085227.GA120901@mtl-vdi-166.wap.labs.mlnx>
References: <20210530063128.183258-1-elic@nvidia.com>
 <20210530040458-mutt-send-email-mst@kernel.org>
 <20210530081536.GA119906@mtl-vdi-166.wap.labs.mlnx>
 <20210530041624-mutt-send-email-mst@kernel.org>
 <20210530082646.GA120333@mtl-vdi-166.wap.labs.mlnx>
 <20210530043536-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210530043536-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2021 08:52:32.6700
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 62d72eb7-7ecf-4946-c630-08d923484391
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT006.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5531
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 30, 2021 at 04:36:17AM -0400, Michael S. Tsirkin wrote:
> On Sun, May 30, 2021 at 11:26:46AM +0300, Eli Cohen wrote:
> > On Sun, May 30, 2021 at 04:19:01AM -0400, Michael S. Tsirkin wrote:
> > > On Sun, May 30, 2021 at 11:15:36AM +0300, Eli Cohen wrote:
> > > > On Sun, May 30, 2021 at 04:05:16AM -0400, Michael S. Tsirkin wrote:
> > > > > On Sun, May 30, 2021 at 09:31:28AM +0300, Eli Cohen wrote:
> > > > > > Fix copy paste bug assigning umem1 size to umem2 and umem3.
> > > > > > 
> > > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > > > > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > > > > 
> > > > > could you clarify the impact of the bug please?
> > > > > 
> > > > 
> > > > I leads to firmware failure to create the virtqueue resource when you
> > > > try to use a 1:1 mapping MR. This kind of usage is presented in the
> > > > virtio_vdpa support I sent earlier.
> > > 
> > > OK pls include this info in the commit log.
> > OK
> > 
> > > And is 1:1 the only case where
> > > sizes differ? Is it true that in other cases sizes are all the same?
> > > 
> > The sizes are calculated based on firmware published paramters and a
> > formula provided by the spec. They do differ but it so happened that
> > size1 was larger than size2 and size3 so we did not see failures till
> > now.
> 
> can this have a security impact? e.g. can guest access addresses
> outside of it's memory with this?
> 

No, this memory is accesible only by firmware for its internal use.

> > > > > > ---
> > > > > >  drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> > > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > 
> > > > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > > > index 189e4385df40..53312f0460ad 100644
> > > > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > > > @@ -828,9 +828,9 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque
> > > > > >  	MLX5_SET(virtio_q, vq_ctx, umem_1_id, mvq->umem1.id);
> > > > > >  	MLX5_SET(virtio_q, vq_ctx, umem_1_size, mvq->umem1.size);
> > > > > >  	MLX5_SET(virtio_q, vq_ctx, umem_2_id, mvq->umem2.id);
> > > > > > -	MLX5_SET(virtio_q, vq_ctx, umem_2_size, mvq->umem1.size);
> > > > > > +	MLX5_SET(virtio_q, vq_ctx, umem_2_size, mvq->umem2.size);
> > > > > >  	MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id);
> > > > > > -	MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem1.size);
> > > > > > +	MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size);
> > > > > >  	MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn);
> > > > > >  	if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, eth_frame_offload_type))
> > > > > >  		MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1);
> > > > > > -- 
> > > > > > 2.31.1
> > > > > 
> > > 
>